search

MinecraftForge / ForgeFlower

Forge's modifications to FernFlower. Fixing various bugs/inconsistencies. Main Repo: https://github.com/MinecraftForge/FernFlower
Apache License 2.0
80 stars 44 forks source link

Add pattern matching instanceof #112

Open coehlrich opened 2 years ago

coehlrich commented 2 years ago

22w11a diff 1.18.2-rc1 diff

Fixes the compile error where a generic is assigned into a variable with the type StringReader here in 22w11a.

Doesn't currently support the way ecj compiles pattern matching instanceof which does the cast twice and check if the casts are the same as well as registering the generated variable in the local variable table.

pupnewfster commented 2 years ago

Wouldn't a better solution be to rebase against upstream which in theory has had this support since early december? https://github.com/MinecraftForge/FernFlower/commit/91cf425e9b35d7cf4816d15ecc8a4422cba87d86

zml2008 commented 2 years ago

Closing in favor of #114, thanks though!

SizableShrimp commented 1 year ago

This appears to be a draft because it supposedly has improvements over upstream which need to be rebased & reevaluated.