Zip file instances lock on all reads, so we should try to
load everything we need into memory all at once, rather than
reading multiple times
This does have some negative impact on base memory usage, but reduces allocations from file reads quite a bit, so it's probably about a wash on that front.
These changes knock about 10s off the runtime to decompile 1.18.2 (~40s to ~30s) on my machine (Ryzen 7 3800x, win 11, 64gb ram, SSD), with no change to the output.
Further work on true lazy loading of classes is upcoming, but this was a change with way lower impact, and where my work started so I pulled it out on its own.
Some reports from JFR that led to these changes:
Original
After introducing the ZipFile cache (step 1)
After caching data in the LazyLoader link (step 2)
(yes, this abuses LazyLoader, but LazyLoader is dumb and I don't care)
Zip file instances lock on all reads, so we should try to load everything we need into memory all at once, rather than reading multiple times
This does have some negative impact on base memory usage, but reduces allocations from file reads quite a bit, so it's probably about a wash on that front.
These changes knock about 10s off the runtime to decompile 1.18.2 (~40s to ~30s) on my machine (Ryzen 7 3800x, win 11, 64gb ram, SSD), with no change to the output.
Further work on true lazy loading of classes is upcoming, but this was a change with way lower impact, and where my work started so I pulled it out on its own.
Some reports from JFR that led to these changes:
Original
After introducing the ZipFile cache (step 1)
After caching data in the LazyLoader link (step 2)
(yes, this abuses LazyLoader, but LazyLoader is dumb and I don't care)