search

MinecraftForge / ForgeFlower

Forge's modifications to FernFlower. Fixing various bugs/inconsistencies. Main Repo: https://github.com/MinecraftForge/FernFlower
Apache License 2.0
80 stars 44 forks source link

Allow renaming of the parameters in JAD mode #119

Closed marchermans closed 1 year ago

marchermans commented 1 year ago

This adds a configuration option to enable parameter renaming in JAD mode.

marchermans commented 1 year ago
  • Rather than an added patch, please amend the "JAD Style variable naming" patch, currently 0012 -- you're only making minor edits to files added in that patch.

I am actually having a difficult time doing this. Lex requested this but I am really in the struggle bus here.

zml2008 commented 1 year ago

I'm just on mobile rn, but the steps really arent that different from a normal git repo - it's just dealing with patches on either end

just:

  1. apply patches
  2. cd into the patched repo
  3. git rebase -I origin/upstream
  4. in the editor, put your commit as a fixup after the Jad varnaming commit
  5. exit, fix any conflicts if they come up
  6. cd back out, make patches

On Mon, Nov 7, 2022, at 00:29, Marc Hermans wrote:

  • Rather than an added patch, please amend the "JAD Style variable naming" patch, currently 0012 -- you're only making minor edits to files added in that patch. I am actually having a difficult time doing this. Lex requested this but I am really in the struggle bus here.

— Reply to this email directly, view it on GitHub https://github.com/MinecraftForge/ForgeFlower/pull/119#issuecomment-1305254008, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEZSZE2GK7S4XMIER6JH3DWHC4X5ANCNFSM6AAAAAARQ5W76E. You are receiving this because you commented.Message ID: @.***>