MinecraftForge / ForgeFlower

Forge's modifications to FernFlower. Fixing various bugs/inconsistencies. Main Repo: https://github.com/MinecraftForge/FernFlower
Apache License 2.0
80 stars 44 forks source link

Rebase on top of upstream FernFlower #60

Closed covers1624 closed 4 years ago

covers1624 commented 4 years ago

Empty blocks no longer have semicolons, Minor import fixes, Dropped 3 commits as the changes exist upstream now. mc 1.16-pre1 diff

Still requires j9+ testing.

covers1624 commented 4 years ago

Tested Java8 vs Java11 vms I had on hand, no differences in decompile output. Jar was build with the latter Java11 vm.

openjdk version "1.8.0_242"
OpenJDK Runtime Environment (build 1.8.0_242-b08)
OpenJDK 64-Bit Server VM (build 25.242-b08, mixed mode)
openjdk version "11.0.6" 2020-01-14
OpenJDK Runtime Environment (build 11.0.6+10)
OpenJDK 64-Bit Server VM (build 11.0.6+10, mixed mode)
LexManos commented 4 years ago

Diff looks good, changes look good. We still need to re-evaluate the unboxing changes as discussed on discord. But I have the JVM tests running right now if they all pass I'll tag and pull.