Closed sciwhiz12 closed 3 years ago
Per feedback from Lex, I've removed the caching issue bugfix/workaround described in the second-to-last paragraph of the PR description, as it still needs further investigation as to the actual root cause of the problem.
Upon further investigation (using a seperate Linux install), I've determined the issue to be local to my Windows installation on my machine. Therefore, the fix/workaround will remain removed.
Sorry I forgot about this, and thanks for doing it. Just a cleanup I never got time to do.
Updates the Gradle wrapper to 6.8.1 and moves the project to use the new Java Toolchains feature.
In short, Java Toolchains, added in Gradle 6.7 and enhanced in 6.8, is a feature that allows Gradle projects to define what JDK versions to use for the project and/or individual tasks, and automatically downloads them if missing and uses those JDKs. This allows for developers for ForgeFlower to not have to install JDK 8 and/or 9 by themselves, by having Gradle do the downloading automatically. (The installed JDKs and the downloaded JDKs are used in other projects that use Java Toolchains too, when needed.)
This also includes a small fix to a bug I've been encountering where deleting the built JARs or even theSee comment below.build
folder in theForgeFlower
subdirectory does not allow recompilation of the classes and the rebuilding of the JARs, by forcing thejar
task (and any otherJar
task such assourcesJar
) to always run and ignore theUP-TO-DATE
. This shouldn't really affect anything, as it only goes into effect when you build the project.Also has some general buildscript cleanup.
tags: true
to thegrgit.describe
call.eclipse
plugin automatically; it now creates the task only if it does not exist first.