MinecraftForge / ForgeGradle

Minecraft mod development framework used by Forge and FML for the gradle build system
GNU Lesser General Public License v2.1
522 stars 444 forks source link

Exceptions are added with setupDecompWorkspace, but not with setupCIWorkspace #390

Closed octylFractal closed 4 years ago

octylFractal commented 8 years ago

In my Decomp workspace, DataSerializer.java looks like this:

public interface DataSerializer<T>
{
// ...
    T read(PacketBuffer buf) throws java.io.IOException;
// ...
}

However, when a CI workspace is used, it looks like this (from a forgeBin jar decompiled):

public interface DataSerializer<T>
{
 // ...
  public abstract T read(PacketBuffer paramPacketBuffer);
  // ...
}
TehNut commented 8 years ago

IIRC, setupCIWorkspace only does the minimal amount needed for building. It's not meant for use in a dev environment.

diesieben07 commented 8 years ago

What you are seeing is decompiled like you said. Decompiled code looks different.

LexManos commented 8 years ago

Guys shutup unless you know what you're talking about. Exceptions are added pre-decompile in the same step for both decomp and ci so it should be adding them.

octylFractal commented 8 years ago

@TehNut @diesieben07 If you had read the title, you would have noticed this is not about source vs. decompiled but the presence of exceptions, which causes compile errors if they're not there (see the travis build that alerted me to this)

diesieben07 commented 8 years ago

Reading the title definitely helps. Sorry.

AbrarSyed commented 8 years ago

hmm.. something is wrong with the application od the Exceptor.. had this bug before an it was fixed.. what hapenned recently?

liach commented 7 years ago

@kenzierocks Agrees. See https://github.com/CovertJaguar/Railcraft as an example. When you run ./gradlew build it fails; but when you run ./gradlew setupDecompWorkspace build it succeed.

liach commented 7 years ago

@kenzierocks How about setupDevWorkspace?

DaemonUmbra commented 4 years ago

Closing this issue as it does not appear to be applicable to the currently supported ForgeGradle branch (FG_3.0).

If I am incorrect in this regard, please create a new issue prefixed with [FG_3.0] and containing:

Note that an ongoing effort to update legacy MinecraftForge branches to utilize FG_3.0 is ongoing and accepting informed contributions. (For more information join the Discord and read through the #mcpconfig channel)