MinecraftForge / ForgeGradle

Minecraft mod development framework used by Forge and FML for the gradle build system
GNU Lesser General Public License v2.1
516 stars 443 forks source link

Properly queue creation of reobf tasks for JarJar tasks #884

Closed Jonathing closed 2 years ago

Jonathing commented 2 years ago

Fixes #883.

Additionally, I have moved the call to whenTaskAdded above the call to configureJarJarTask so that the primary JarJar task that is created by ForgeGradle can be effected by this as well.

Jonathing commented 2 years ago

Closing this as an invalid solution to #883 (and by extension #881). configureEach does in fact work but is negated by how JarJar tasks on creation are disabled by default until the end user in their own build.gradle file enables it manually or includes a JarJar dependency. I shall leave it up to our friends @OrionDevelopment and @SizableShrimp 🦐. Here's a screenshot basically summarizing what we talked about in #gradle today.

Related Discord Message

https://discord.com/channels/313125603924639766/801175194298744902/1009874822177751101

Farewell, chat.