MinecraftForge / ForgeGradle

Minecraft mod development framework used by Forge and FML for the gradle build system
GNU Lesser General Public License v2.1
508 stars 437 forks source link

Replace SpecialSource RenameJar args instead of appending them to default FART args #931

Closed Barteks2x closed 1 year ago

Barteks2x commented 1 year ago

This commit https://github.com/MinecraftForge/ForgeGradle/commit/8cde2f12813438d659fe467fa6cadbf03f8d5473 switched to using FART in rename task and exposed a bug in this code that uses SpecialSource - it's appending SpecialSource args instead of replacing them, which meant that in case of old versions (1.12.2 only?) where this code runs it was running with both FART and SpecialSource args.

This also appears to work correctly when using FART here instead of SpecialSource, so I'm not entirely sure if this is the correct way to fix this. The TODO comment seems to indicate that it should be using FART but I don't know exactly what would be required to do this.