Shears on trapwire drops string instead of deactivating it - Githubissues

MinecraftForge / MinecraftForge

Modifications to the Minecraft base files to assist in compatibility between mods. New Discord: https://discord.minecraftforge.net/

https://files.minecraftforge.net/

Other

6.93k stars 2.69k forks source link

Shears on trapwire drops string instead of deactivating it #9900

Closed GatoVuelta closed 6 months ago

GatoVuelta commented 7 months ago

Minecraft Version: (≤?) 1.20.x (Tested 1.20.1 and 1.20.4)

Forge Version: (≤?) 47.2.23 - 49.0.39

Logs: Not applicable

Steps to Reproduce:

Create a simple tripwire mechanism like the following:

Left click with a shear on your main hand on any placed string along the tripwire
Expected vanilla behavior: The trap deactivates without detaching/destroying it. Actual behavior: It destroys the trap, dropping the placed string

A bit surprised this wasn't reported before, or at least I couldn't find anything about it. Seems to be happening on previous versions too, as reported by some Reddit users: https://www.reddit.com/r/feedthebeast/comments/19bl93c/shears_dont_properly_work_on_forge_1201/?onetap_auto=true&one_tap=true https://www.reddit.com/r/Minecraft/comments/12isccj/forge_disables_shears_cutting_tripwire/

KnightMiner commented 7 months ago

This is not a forge bug, this is forge fixing a vanilla bug. Left clicking tripwire with shears in vanilla leads to a broken blockstate that now is randomly unbreakable, its clearly not intended behavior. It is also notably inconsistent with Bedrock without the forge fix.

If you want the so called "deactivating without breaking", its trivial to write a mod that makes right clicking with shears add that in a way that is not completely broken.

For reference, see #7718, neoforged/NeoForge#338 and MC-129055