Doesn't handle remapping lambdas or method refs

MinecraftForge / Srg2Source

Applies source level refactors to java source code.

GNU Lesser General Public License v2.1

60 stars 32 forks source link

Doesn't handle remapping lambdas or method refs #9

Closed matthewprenger closed 8 years ago

matthewprenger commented 8 years ago

ForgeGradle uses Srg2Source to create srg named source jars, and later remap those jars to the target mcp snapshot version. Method refs and lambdas aren't getting remapped with the rest of the methods/fields.

LexManos commented 8 years ago

Ya it probably doesn't. There's a reason we target Java 6. Wonder what the AST looks like for this stuff.

LunNova commented 8 years ago

Related/same issue with lambdas causing an NPE at SymbolRangeEmitter.java:113

This seems to be the simplest class which causes it: https://gist.github.com/nallar/12e78ab93bf160a6e087

Example repo which encounters the crash on ./gradlew build: nallar/Srg2SourceCrash

LexManos commented 8 years ago

Issue was in Eclipse's JDT library. Updating it fixed it. However, it needs more testing as I don't know what bugs updating introduced. I don't think it added any, or added a hard derp to J8, but needs tests.