search

MinecraftForge / SrgUtils

A library for working with SRG, and other mapping variants.
GNU Lesser General Public License v2.1
12 stars 16 forks source link

Fix loading parameter comments from tiny format #10

Closed theWituch closed 2 years ago

theWituch commented 2 years ago

When checking for comment to add in tiny format, check order must be reversed to nodes hierarchy in mapping. Otherwise, parameter comment will overwrite method comment.

Additionally, escape comment when saving metadata in the tiny format.

LexManos commented 2 years ago

Provide examples, or something I can test.

theWituch commented 2 years ago

Example tiny mapping to test https://pastebin.com/EDB52yuQ

I can write appropriate tests for different types of mappings for future reference if needed.