search

MinecraftForge / SrgUtils

A library for working with SRG, and other mapping variants.
GNU Lesser General Public License v2.1
12 stars 16 forks source link

ProGuard reader crashes when encountering descriptors which contain root-level classes #20

Closed NebelNidas closed 2 months ago

NebelNidas commented 2 months ago

Classes without package lead to a crash, since non-primitive types are only recognized if they contain a /: https://github.com/MinecraftForge/SrgUtils/blob/917096ea6a3a8087c564d90a86c8ec236f9a96c6/src/main/java/net/minecraftforge/srgutils/InternalUtils.java#L568-L569

LexManos commented 2 months ago

You need to provide real world functional examples when filing reports.

NebelNidas commented 2 months ago 
class1 -> class1Rename:
    class2 field1 -> field1Rename

should do

NebelNidas commented 2 months ago

Thanks! :)