MinecraftFreecam / Freecam

A highly customizable freecam mod for Minecraft.
https://curseforge.com/minecraft/mc-mods/free-cam
MIT License
73 stars 26 forks source link

Compatibility with Epic Fight #113

Open Mnibr opened 11 months ago

Mnibr commented 11 months ago

There is a minor compatibility issue that can cause Epic Fight to malfunction when paired with Epic Fight. I know this is a compatibility bug that is not within your consideration range, but I still want to anticipate it. If it is not difficult to fix, please

MattSturgeon commented 10 months ago

I can't see any Freecam related issues reported on Epic Fights github.

My gut feeling is that this is more likely to be an issue with that mod than this one, I'd recommend reporting an issue there which references this one.

Either way, some more detail would be useful. What exactly is the "minor compatibility issue"? How exactly does it "malfunction"? What was the expected behavior?

Mnibr commented 10 months ago

我在 Epic Fights github 上看不到任何与 Freecam 相关的问题。

我的直觉是,这更有可能是该模组的问题,而不是这个模组的问题,我建议在那里报告一个引用这个问题的问题。

无论哪种方式,更多细节都是有用的。究竟什么是“次要兼容性问题”?它究竟是如何“故障”的?预期的行为是什么?

I reported discord during the epic fight

我在 Epic Fights github 上看不到任何与 Freecam 相关的问题。

我的直觉是,这更有可能是该模组的问题,而不是这个模组的问题,我建议在那里报告一个引用这个问题的问题。

无论哪种方式,更多细节都是有用的。究竟什么是“次要兼容性问题”?它究竟是如何“故障”的?预期的行为是什么?

I have received feedback from the epic fight team about discord (but they seem unwilling to fix it). When Freecam is started, there may be a problem with the mode switching of the epic fight

MattSturgeon commented 4 months ago

I've tried installing Forge 47.2.32, Freecam 1.2.1+1.20, & Epic Fight 20.7.4, however I was unable to reproduce the issue.

I was able to switch "mode" (keybind R) both before and after using Freecam (keybind F4).

I also tried enabling Freecam's "Allow Interact" with mode "Player" to see if attacking while Freecam is enabled could cause issues, but the only issue I found was that Epic Fight's custom animation would (briefly) render from the player's perspective while attacking, instead of the camera's.

This testing was conducted in singleplayer (survival).

TheRiverElder commented 2 months ago

Somehow, this bug only appears in multiplayer games. Both mods work well in single player game;

Player enters server;
    Epic Fight attacking works;
    Player used Freecam and than exit freecam mode;
    Epic Fight attacking doesn't work(no animation ferformed, no damage triggered);
    Vanilla attacking works;
Player exits server;
Player re-enters server:
    goto Player enters server

Maybe it is caused by MinecraftMixin.onDoAttack; (Not sure, I am not able to setup modding enviroument to do testing.)

Minercraft: 1.20.1 Forge: 47.3.0 Freecam: 1.2.1 Epic Fight: 20.7.4