search

MinecraftFreecam / Freecam

A highly customizable freecam mod for Minecraft. [Maintiners: @hashalite @MattSturgeon]
https://curseforge.com/minecraft/mc-mods/free-cam
MIT License
75 stars 30 forks source link

Merged jar #144

Closed MattSturgeon closed 10 months ago

MattSturgeon commented 10 months ago

Since our platform-specific code is so small, it may be worth it to provide a "merged jar".

I think this only makes sense when all builds remap to the same mappings. If one platform uses notch at runtime and the other uses searge, there's no point merging the jars.

However, if both platforms use notch*, we may as well bundle both sets of metadata & platform-specific classes in one jar to simplify installation for end-users.

* I believe this is the case for modern versions.

One way to do this is with plugins like Forgix. We could probably also do it manually using shadow or a custom gradle task that combines each jar's ZipTree.

On the other hand, we could keep things simple and mark this issue as "not planned" :smiley:

MattSturgeon commented 10 months ago

Not sure this is worth the effort or potential downsides.