search

MinecraftFreecam / Freecam

A highly customizable freecam mod for Minecraft.
https://curseforge.com/minecraft/mc-mods/free-cam
MIT License
74 stars 27 forks source link

Incompatibility with "Hot Swap [Fabric]" by "thepeebrain" #184

Open SamHammie opened 5 months ago

SamHammie commented 5 months ago

Description of the issue

When I turn on the freecam mode, the functionality of "Hot Swap [Fabric]" version by "thepeebrain" gets completely disabled, and the only way to fix it is to leave and rejoin the world you're in.

Expected behavior

I expected the functionality of the other mod to continue working.

Steps to reproduce

  1. Join a multiplayer server (I have yet to replicate this in single player)
  2. Enable Freecam by pressing F4
  3. The functionality of the other mod is disabled until you leave and rejoin the server

Log output

View them here.

Crash report

Not applicable.

How prevalent is the issue?

Every time I activate freecam mode after rejoining the world.

Freecam version

1.2.1+1.20

Are you using "Modrinth Edition"?

No

Minecraft version

1.20.1

Modding platform

MattSturgeon commented 5 months ago

Before looking into this properly, my first instinct is that this is probably an issue with Hot Swap rather than Freecam. Thanks for reporting the issue there too.

Looking through their code, this bit where they cache the current player is very suspicious.

I suspect when Freecam "spawns", their cached player becomes the camera (bug), and when Freecam "despawns" their cached player becomes null (bigger bug).