MinecraftFreecam / Freecam

A highly customizable freecam mod for Minecraft.
https://curseforge.com/minecraft/mc-mods/free-cam
MIT License
73 stars 26 forks source link

Freecam's entity is visible when used with First Person Model mod #185

Closed noah123586 closed 2 months ago

noah123586 commented 5 months ago

Description of the issue

free cam will put me into a steve body or alex body and show them as if they where swimming

every time I enter freecam mode, it would put me into a steve or alex body. 2024-03-08_12 28 10

Expected behavior

the mod to work fine just as it did in the same version, just a different modpack

Steps to reproduce

  1. Open a singleplayer world
  2. Enable Freecam by pressing v
  3. ...

Log output

No response

Crash report

No response

How prevalent is the issue?

every time i turn on free cam

Freecam version

1.2.3

Are you using "Modrinth Edition"?

No

Minecraft version

1.18.2

Modding platform

MattSturgeon commented 5 months ago

just a different modpack

This sounds like a compatibility issue. What mods are you using?

If you can, please try disabling them one-at-a-time and reporting back which mod being disabled resolved the issue.

3ncanis commented 4 months ago

Experiencing this as well, @noah123586 if you could post your mod list it would make determining which mod is causing the conflict much easier.

MattSturgeon commented 4 months ago

It'd be great if both of you (and anyone else affected) could share what mods you're using.

This may help us narrow down the cause and investigate whether there's anything we can do to fix or work around the issue on our end.

noah123586 commented 4 months ago

it's https://www.curseforge.com/minecraft/mc-mods/first-person-model sorry for taking so long to reply. i got rid of this mod and freecam worked fine.

MattSturgeon commented 4 months ago

it's FirstPersonModel sorry for taking so long to reply. i got rid of this mod and freecam worked fine.

Interesting.

50 and https://github.com/tr7zw/FirstPersonModel/issues/291 are apparently resolved, but there could've been a regression... Maybe when we switched to using the swimming pose?

MattSturgeon commented 3 months ago

@noah123586, I hope you don't mind, but I'm re-opening this as the bug still isn't fixed.

Feel free to unsubscribe if this issue no longer interests you:

image

MattSturgeon commented 3 months ago

To @AzuryxxVortex and anyone subscribed here: do you also get this issue with old versions of First Person Model and/or old versions of Freecam?

As this issue was supposedly fixed in this commit (which I think was first released in FPM v2.2.0), it'd be interesting to know if something they've done or something we've done has broken the compatibility.

AzuryxxVortex commented 3 months ago

To @AzuryxxVortex and anyone subscribed here: do you also get this issue with old versions of First Person Model and/or old versions of Freecam?

I've not tested it before, but I will try to downgrade and see with all 3 versions of Freecam there currently is on Modrinth. See if it was on this side...

AzuryxxVortex commented 3 months ago

All three have the same issue, it wouldn't appear to be from there. image

I'll attempt the other way around then.

AzuryxxVortex commented 3 months ago

Same issue persists across all versions of FPM, it seems to simply be broken for all of 1.20 and upwards I'd assume.

AzuryxxVortex commented 3 months ago

Update The issue is only fixed on the Fabric version of FMP, but it persists in Forge.

MattSturgeon commented 3 months ago

Good work! It looks like FPM will need to extend their Freecam support to their Forge version too then.

While I don't think it's directly related, I should also highlight this commit added in Freecam v1.2.1 which works around a Forge quirk that broke our "show player" option.

Essentially, Forge prevents the player being rendering when viewed from Freecam, so we rendered the ourselves instead. This quirk isn't present in Neoforge or Fabric.

As above, I don't think this is related to this issue because we're explicitly rendering the player, not the FreeCamera entity.

MattSturgeon commented 2 months ago

FPM has fixed this in https://github.com/tr7zw/FirstPersonModel/commit/81c5124354a346624075d5878a9e8740f2baa34c, which I believe will make it into their next release. You can download pre-release snapshot builds here (click on "Artifacts" to download).

Let me know if that doesn't work and I'll re-open this issue.

AzuryxxVortex commented 2 months ago

Tested it out, I can say that it works- Thanks!

MattSturgeon commented 2 months ago

Tested it out, I can say that it works- Thanks!

Thanks for letting us know, but don't thank me - thank @tr7zw!