MinecraftFreecam / Freecam

A highly customizable freecam mod for Minecraft. [Maintiners: @hashalite @MattSturgeon]
https://curseforge.com/minecraft/mc-mods/free-cam
MIT License
75 stars 31 forks source link

Night vision goes away when activating freecam #191

Open OverWims opened 8 months ago

OverWims commented 8 months ago

Description of the issue

Night vision goes away whilst in freecam if you have the night vision effect active.

Expected behavior

Night vision not to go away

Steps to reproduce

give yourself nightvision and go into freecam.

Log output

No response

Crash report

No response

How prevalent is the issue?

everytime i go in freecam whilst night vision is active

Freecam version

1.2.3

Are you using "Modrinth Edition"?

No

Minecraft version

1.20.4

Modding platform

MattSturgeon commented 8 months ago

Thanks for taking the time to report your issue. Unfortunately I can't reproduce the issue.

Testing in a singleplayer world on the latest dev branch*, I run:

/effect give @s minecraft:night_vision infinite

When switching to Freecam brightness doesn't change.

Running the following (in freecam) makes the screen notably darker:

/effect clear @s minecraft:night_vision

* basically identical to 1.2.3


It'd be great if you could explain exactly how to reproduce this issue, or perhaps any mods you have installed that are likely to conflict here.

There is a potential workaround for you though: in Freecam's "Visual Options" there is a "Full Brightness" option, which maxes-out gamma while Freecam is active.

OverWims commented 8 months ago

Hi, I can't really tell you exactly how to reproduce it (other than what I said before) as if I knew how to do that, I wouldn't have this problem as I'd disable/remove whatever was causing it.

The full brightness thing doesn't seem to help (night vision is brighter than max gamma). I have the full bright resource pack (removing doesn't make a difference), ComplementaryUnbound shaders (removing doesn't make a difference). Removing both also doesn't make a difference. My brightness is on Bright (setting to Moody doesn't make a difference). Smooth Lighting and Smooth Lighting Level are both set to off. Dynamic Lights is set to off.

Other mods I have are Minihud, Optifabric and Optifine. Switching to Sodium/Iris isn't something I want to do as I like Optifine too much.

I have tested on single and multiplayer and either way it does it.

Edit: Quick question, did you see a difference with and without night vision before going into freecam as it can sometimes be difficult to see the difference if you don't have any shaders on etc. And if you didn't notice the difference, you wouldn't have noticed night vision not being on when going into freecam mode as you still have the enchant shown as active, you just don't see the effects of it.