Closed D3nnis3n closed 7 years ago
Just Forget it. Forgot to Change the config to not use MMDOreSpawn beforehands. I'm dumb today. Sorry!
There is something screwy going on here - OreSpawn being present or not and that config option should have no effect in the code, really. What I'd expect to happen is to get a "Missing Mod Exception" - what is happening is that it seems to think that the "human_detector" block isn't getting a registry name.
I'm re-opening this and investigating deeper.
Haha, lol. Even when i'm just dumb, i find Bugs :D
Nah - see... you should have gotten a nice screen telling you that MMD OreSpawn 3.1.0 was required, triggered by a "Missing Mod Exception". Instead you find something really intriguing
And my tests come up with a completely different error to dshads tests.
Found the issue... Apparently the event handlers for the Registry Events get called regardless of the error state of the FMLPreInitializationEvent handlers for the "Pre Initialization" phase of mod loading. This was causing it to try and register a block that had never been initialized, because the code to initialize it had never been called.
Upcoming PR fixes it.
Yeh, i understand what the Problem was. Anyways, PR seems to be merged but no new build of BaseMetals or ModernMetals is on the Maven g
Despite that, we consider both mods as stable for public usage now (sureley under the hood it might not be considered so) - they're fully usable and in our case we have not gotten any Crash Problems. Until now, to be exact, no Problems (despite Diamonds) have been reported to me. I saw UtilityOres have been released. So i got hopes for the other mods now 🗡
But i didn't really understand who works on what - as it seems like you are multiple people.
Anyways, whenever you start working on the other mods, i'll be here to help you find bugs. And if i still get reported something from base or modern metals, i'll tell you.
This is fixed in an upcoming PR - it will still crash, but the crash will be a "Missing Mods Exception" and tell you that you need MMD OreSpawn of at least 3.1.0
Yah, i misinterpreted "upcoming" for "still to merge, but there". And there was no PR to merge left. Just Forget it. English is not my native language :D
I understand - I have German relatives, grew up around those speaking "Pennsylvania Dutch" (a "Platt Deutsch", if I remember the correct terminology), took it as a class in school and regularly listen to - and understand - German music. Yet I still can't converse in the language. You do better with English than I do German.
The reason for the "Upcoming" is because it's also mixed with a fix for the casting table (which was slightly broken at some point) as well as adding Diamonds to Tinkers'
Pretty cool. "Plattdeutsch" is the dialect of german people in the North - does not sound good, if you ask me g. I'm from bavarian-swabia. You would not be able to understand a single word, if i start talking in my dialect g Noone does, that lives further away then 20 kilometres. (Dunno what's that in miles)
It's something like 0.6km per mile - so call it somewhere around 12 miles (this is inaccurate as all heck, but...)
Wouldn't it be 1.6 km per Mile then? Or am i dumb?Otherwise you would get more miles, wouldn't you?
Still don't understand why you don't use metrics. Driving on the right, but no metrics. Crazy.
(and yes, considering "Deutsch" becomes "Deitsch" in "Die Pennsylvanische Deitch", I do understand about the dialects)
Pennsylvania Dutch is not "Plattdeutsch", it's based on a Palatine dialect, which you can find in Bavaria, too. But it's mostly similar to something spoken in the west of Germany, not the north.
"Deitsch" is something we in Bavaria also say. In the North it would be more like "düttsch".
eh, it's been about 20 years since I was in school :) That's enough time for memories to fade and erode
Haha, yeh. I was just pretty surprised when you said "Deitsch" - as we do say that, too and looked up what "Pennsylvania Dutch" ist. As of it being Palatine, it has some similarities with my dialect while northern german has none at all.
I also really hate my auto correction that writes words in upper case letters at the beginning ... It does not understand i'm not writing in german now.
Alright - working on one last test before the big push, which will include Diamond&Emerald -> dust in Mek and IC2 and Diamond Ore and Emerald Ore the same. It will also add Diamond Gear, Gem and Nugget to the Smeltery, Emerald Gear and Nugget to the same, Fix the crash you found to be in the proper form (this issue), update to Forge 14.22.1.2485 (latest for 1.12.1) and the latest mappings, while also fixing the issues that arose from some names being changed in the same.
This leaves: 1) Move OreDictionary work to the Item/Block registration events - this should solve the issues with JAOPCA 2) Re-enable Thermal Expansion integration fully and fix any problems that might exist in that plugin currently (and hope the old issue that was happening... isn't, anymore) 3) Conference with @jriwanek and the rest of the team about Advancements and what to implement, if anything
Nice. Would help you out, but i hate coding. We in Germany got two ways for informatic education (i don't know how the thing you need to do to be able to do an specific "Job" later is called) for Information Technologies - one is the it-sysadmins and hardware guys and the other one is the developers. I'm one of the first ;) So i indeed do understand what you're doing but am pretty happy other people do it, so we can play great things g
😄 I do embedded electronics as a hobby and have had jobs on both sides of that line. I do like the programming, but I absolutely love the smell of hot solder and seeing something I designed work.
Is "apprenticeship" the correct word? Anyways, it's called "Fachinformatiker für Systemintegration" here.
Hrm... perhaps - it'd imply that you learn by doing while under the supervision of one who has mastered their trade and been recognized as such by their peers
Yeh, for 2 - 3 years with low pay, some weeks in a school and lead by a employee that has the right to teach you. At the end you get a certificate from the state and can apply to a Job with higher pay, as you now know what you should be knowing to do it.
Fixed in #197 - closing
Yes, i know - it's made for 1.12.1, but because every other mod i have (200) work, you maybe are able to make your mod work in 1.12.2, too?