MinecraftModDevelopmentMods / BaseMetals

Base Metals Mod
https://www.curseforge.com/minecraft/mc-mods/base-metals
GNU Lesser General Public License v2.1
16 stars 18 forks source link

Return of the Broken Villager #438

Open Hexblood opened 5 years ago

Hexblood commented 5 years ago

Minecraft version: 1.12.2 Forge version: 14.23.5.2836 Base Metal version: 1.12-2.5.0-rc1.322

Issue:

Blacksmith Villagers are filled with many blank trades. It does not matter if the Villager Trades config is set to true or false. I do have several materials disabled if that matters.

Suggested fix:

I would suggest either get the config working or remove this feature from live version till the issue can be more completely fixed. I noticed this issue has been reported and fixed several times.

dshadowwolf commented 5 years ago

damn, another f*cking broken config on top of everything else. The "config is not disabling" is likely fixed in -dev already - let me see if I can ping the person that understands that code... @jriwanek we've got another bug in VillagerTrades!