search

MinecraftModDevelopmentMods / Extra-Golems

Forge mod that adds dozens of golems to Minecraft
Other
19 stars 6 forks source link

Fix MinecraftModDevelopmentMods/Extra-Golems#113 #116

Closed leterio closed 1 year ago

leterio commented 1 year ago

The cause for this issue is due the maps GOLEM_CONTAINER_MAP and GOLEM_MODEL_MAP being empty when player loads a world and not being populated before the first load of a Golem MOB, so, causing a fail on the method setMaterial that fallsback to a "empty" golem.

The fastest way I've found to fix the issue is including a callback on the class CodecJsonDataManager that, after loading the models from jsons, populate the respective map (cited above).

Of course, is possible to simplify the implementation with a simple call to putAll on the constant Map directly, inside the class CodecJsonDataManager, removing the Consumer<> parameter.

skyjay1 commented 1 year ago

I'm actually working on this right now, currently in the process of throwing out the custom JSON reload listener in favor of Forge's datapack registries. I'll take a look at your PR to see what I can incorporate, thanks!

skyjay1 commented 1 year ago

The codebase was reworked and the requested changes are no longer compatible