search

MinecraftModDevelopmentMods / MMDLib

new MMDLib
https://www.curseforge.com/minecraft/mc-mods/mmdlib
GNU Lesser General Public License v2.1
5 stars 9 forks source link

IoC added, Junit Added, Tab Provider Interface added #2

Closed SkyBlade1978 closed 6 years ago

SkyBlade1978 commented 6 years ago

This is the first step towards replacing the TabContainer, and the most important files to get right in this PR (I believe) are the new tabprovider interfaces as the concretions coming in a later PR will be based on them.

@jriwanek @dshadowwolf @faceofcat If you can see any flaw with, especially the interfaces please it'll be good (good to find them now), happy to explain how I imagine a concretion of the interfaces working.

The tabcontainer is now deprecated as its on the way out, its now wrapped in the new interface as part of my process of refactoring it out, the same process will need to happen in BMe.

As part of this PR of course all the unit testing framework has been added, for some reason I had to manually set the classpath for mokito though I'm pretty sure the gradle script should do that so let me know if it doesn't work straight off, probably the PR will fail anyway if that doesn't work.

MinecraftModDevelopmentBot commented 6 years ago

Can one of the admins verify this patch?

MinecraftModDevelopmentBot commented 6 years ago

Can one of the admins verify this patch?

MinecraftModDevelopmentBot commented 6 years ago

Can one of the admins verify this patch?