MinecraftModDevelopmentMods / Tesla-Core-Lib

Minecraft library useful in creating power hungry machines
https://minecraft.curseforge.com/projects/tesla-core-lib
MIT License
6 stars 8 forks source link

Bad multithreading #49

Open LemADEC opened 5 years ago

LemADEC commented 5 years ago

As of industrialforegoing-1.12.2-1.11.6-216 and tesla-core-lib-1.12.2-1.0.15, when placing a IndustrialForegoing block, a Netty thread is doing 5 world access calls when it shouldn't. This is due to net.ndrei.teslacorelib.tileentities.SyncTileEntity.partialSync(SyncTileEntity.kt:110) calling markDirty. https://gist.github.com/LemADEC/21a4eddef9aa2fa31556e6cdaced7048