Closed sandain closed 8 years ago
Commit f09e6ae6566806f5880989429c243436fdfb1c35 and later 9741ca2cdf82978faabbedc8aeb73793ef524612 allows the default theme to pass the w3c html5 tests using the xhtml profile.
Here is a screen grab from my tablet where the interface is still very usable with my finger or the stylus.
And here is one from my phone where the menu buttons are a little too small to use.
Commit c0b4b6206638d416592baf75878ed9616db4d6b0 is a cool trick I found that fixes the small size of the menu on the phone using only CSS.
Is there a way we can convert the macros to output loops. Specifically with create_menu_content()
, I would like to be able in the theme to do something like this (terrible pseudocode)
<nav>
<ul class="menu">
each menu_item as menu {
<li><a href="{menu.uri}"{if menu.active echo class="active"}>{menu.name}</a></li>
}
</ul>
</nav>
Commit c0b4b62 is a cool trick I found that fixes the small size of the menu on the phone using only CSS.
CSS Media queries are nice and very useful
Is there a way we can convert the macros to output loops. Specifically with
create_menu_content()
, I would like to be able in the theme to do something like this (terrible pseudocode)
I'm making an effort to remove all xhtml out of the Perl code, so something like what you posted would be nice so that we could move the menu out as well. Let me give this some thought and see what I can come up with.
I'm making an effort to remove all xhtml out of the Perl code, so something like what you posted would be nice so that we could move the menu out as well. Let me give this some thought and see what I can come up with.
Awesome, that is what I was kind of going for, removing all presentation out of the code. If this was php I would say use something like twig as a theme engine. I have no idea what is out there for perl.
Also notice that you found the full zoomed out map from overviewer, nice!
I've decided to stop development of the "default theme" , and just leave it as a proof of concept. Issue #1 will take care of development beyond the capabilities of this theme.
Edit: I guess I should mention that index.pl
will be retired too in favor of whatever is decided.
With commit 5ab4fdb10a21affb1499af74507240e1b7201f7c, the default theme now gets data directly from Query, and the world content xhtml is now themeable using the new world.xhtml file.
Here is a recent screen capture of the default theme:
Any feedback or suggestions? I'll be working on the world display as I have time.
edit: replace the screenshot with one with the new map feature.