sandain
commented
7 years ago Hi @rrimc69. I'm glad you were able to figure out the issue and get the script working for you.
I haven't added a better link to the manual install instructions yet, but I did come up with a possible solution for your problem that doesn't seem to affect my install. Here is the patch:
diff --git a/mscs b/mscs
index 19a196f..74c7437 100755
--- a/mscs
+++ b/mscs
@@ -31,5 +31,5 @@ MSCS_ARGS="-p $PROG -l $LOCATION -c $MSCS_DEFAULTS $@"
if [ "$USER_NAME" = "$(whoami)" ]; then
msctl $MSCS_ARGS
else
- sudo -u $USER_NAME msctl $MSCS_ARGS
+ sudo "PATH=$PATH" -u $USER_NAME msctl $MSCS_ARGS
fiLet me know if something like that would work for you, and I'll send in the patch.
zanix
rrimc69
Hi, Thanks very much for your script and efforts. I've been using it for quite a while running on several Scientific Linux iterations, currently on 6.8. I've recently had the need to move my VM to a EL7 Centos base (clean, minimal, no desktop). I have discovered some issues with installing mscs. Hopefully I can contribute the beginnings of a fix ..
I have gotten current stable to work but the primary problem I encountered, for my EL7 build at least, is that sudo has it's own ideas on paths in the ENV. I received two errors, one for overviewer.py which I had to manually install due to no EL7 repo (nice dependency chase there too ... :/ ), the other from EL7 sudo when called within your script.
I could reliably find msctl and mscs in my user's path and root's path, and also when I used "su - minecraft". When I ran the mscs script however, sudo could not see the command and throws this error:
sudo: mscs: command not foundThis also appeared to effect your scripts view of overviewer.py, as it too could not be found, no user could find overviewer in their path for that matter. For my system overviewer lives in /opt/Minecraft-Overviewer/overviewer.py, and this error was presented:
which: no overviewer.py in (/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin)Again it seemed like a path issue. Searching with google I found references of sudo "culling" the paths within ENV, see here for one such reference: http://serverfault.com/questions/528096/sudo-passenger-memory-stats-command-not-found
My solution was following your "Manual Install" instructions to fix permissions, then symlinking mscs, msctl found in /usr/local/sbin/, and overviewer.py into /usr/sbin directory. I don't know what wider security implications that would have on use of your script for external facing hosts, but my instance will only ever be local so it works for me.
A couple of suggestions:
World imports worked like a charm, I look forward to tinkering with the new features.
Cheers,
Rory.