MinecraftServerControl / mscs

Powerful command-line control for UNIX and Linux powered Minecraft servers
https://minecraftservercontrol.github.io
BSD 2-Clause "Simplified" License
486 stars 62 forks source link

Overviewer does not work with Minecraft 1.13 #200

Closed whakru closed 5 years ago

whakru commented 5 years ago

after launching the Overviewer (sudo mscs map) mscs-maps-location = /var/www/SITE/public/map_m It creates an empty folder with the name of the world and all. It remains empty .. I did everything according to the documentation.

sandain commented 5 years ago

I just checked and Overviewer is not working on my server either. They must have changed something. I'll try to look into it this weekend.

whakru commented 5 years ago

I just checked and Overviewer is not working on my server either. They must have changed something. I'll try to look into it this weekend.

I figured out that the "Overviewer" does not support version 1.13 in which I am currently working. Moved to mapcrafter ...

sandain commented 5 years ago

A pull request has been submitted to Overviewer for supporting 1.13, but it doesn't look like it will be merged any time soon.

Although the Overviewer project still has a lot of user interest, it appears to have lost the interest of the majority of the developers. Mapcrafter appears to have the same issue (see their README), although it already has full 1.13 support.

Perhaps for MSCS, the best thing we can do is make it easier to switch between mapping programs rather than hard coding one (currently Overviewer) in the script. I'll try to look at the mapping code this weekend and see how easy it would be to make this happen. @whakru, if you already have a patch, could you post it so that I can get an idea of what needs to happen?

whakru commented 5 years ago

Запрос тянуть был представлен Overviewer для поддержки 1.13, но это не похоже , что это будет объединено в ближайшее время.

Хотя проект Overviewer по-прежнему вызывает большой интерес пользователей, он, похоже, утратил интерес большинства разработчиков. Mapcrafter, похоже, имеет ту же проблему (см. Их README), хотя она уже имеет полную поддержку 1.13.

Возможно, для MSCS лучшее, что мы можем сделать, - это упростить переключение между программами отображения, а не жестко программировать одну (в настоящее время Overviewer) в сценарии. Я попытаюсь взглянуть на код сопоставления в эти выходные и посмотреть, как легко было бы это осуществить. @whakru , если у вас уже есть патч, не могли бы вы опубликовать его, чтобы я мог понять, что должно произойти?

The fact is that I left mapcraft separately. I have my personal server for 3 players =) so I do not need difficulties =)

sandain commented 5 years ago

Let's leave this issue open for the time being. I didn't have time this weekend to look into the change I mentioned above (making it easier to change mapping programs).

sandain commented 5 years ago

It looks like Overviewer merged the required changes and should now work with Minecraft 1.13. I'm going to go ahead and close this issue, and open a new one asking for code to make it easier to change mapping programs.