Broken mscs-server-version parsing

MinecraftServerControl / mscs

Powerful command-line control for UNIX and Linux powered Minecraft servers

https://minecraftservercontrol.github.io

BSD 2-Clause "Simplified" License

490 stars 61 forks source link

Broken mscs-server-version parsing #216

Closed Yax closed 5 years ago

Yax commented 5 years ago

MSCS doesn't accept valid version IDs is mscs.properties:

mscs-server-version=1.14.2 Pre-Release 3

Result:

Starting Minecraft Server: worldCan't find string terminator '"' anywhere before EOF at -e line 3.

Adding " around ID doesn't help.

This issue is related to #208. Mojang confirmed that version IDs can have spaces: https://bugs.mojang.com/browse/MC-147870 - bug report has Works As Intended status.

sandain commented 5 years ago

Hi @Yax.

With the changes made in PR #210, I bet it would work if you use something like:

mscs-server-version=1.14.2-Pre-Release-3

That said, the getServerVersion() and getClientVersion() methods need to be updated to work with spaces as was done in PR #210. I'll try to work on this over the weekend.

sandain commented 5 years ago

This should now be working as expected with commit e220b81d3d1bff33ce588fbf40faeaefb32ea593.

@Yax, please let me know if you still experience issues with versions after updating. Thank you for submitting the issue.

sandain commented 5 years ago

Closing this issue as fixed.