search

MinecraftServerControl / mscs

Powerful command-line control for UNIX and Linux powered Minecraft servers
https://minecraftservercontrol.github.io
BSD 2-Clause "Simplified" License
486 stars 62 forks source link

add mscs-jvm-args #228

Closed rickyninja closed 4 years ago

rickyninja commented 4 years ago

Hey @sandain I added some tests too. Please let me know if there are any issues with how tests were implemented.

zanix commented 4 years ago

I've never seen tests for bash/sh before. Neat!

sandain commented 4 years ago

I tried to setup tests for sh before, but didn't like what I had done so I abandoned it. This looks like a nice clean method. Good work!

I was a little confused about the change you made to printf (addition of --) until I did a little research. I learned something new!

I don't have time to test the changes in this PR, but I did look over the code closely and it looks correct. Thank you for working on this @rickyninja.