search

MinecraftServerControl / mscs

Powerful command-line control for UNIX and Linux powered Minecraft servers
https://minecraftservercontrol.github.io
BSD 2-Clause "Simplified" License
486 stars 62 forks source link

query server restarts if shut down #233

Closed sheimer closed 4 years ago

sheimer commented 4 years ago

query server now restarts on requests, if it shut down before (see issue 232 on https://github.com/MinecraftServerControl/mscs/issues/232)

conrad784 commented 4 years ago

this sleep was introduced with #169 , can you debug this behavior with your change?

sheimer commented 4 years ago

in #169 are different people having different problems, i guess.

if in the first 20 seconds, while the sleep is sleeping, a "mscs status" is executed, the user receives a message "offline". But since the service is not yet running, this is not a problem, you just wait, and after the sleep all is good.

if with my fix the sleep is removed, and someone asks the status in the first 20 seconds (or rather how ever long it takes the minecraft server to be up and running, and accepting queries), the socat shuts down. but, on next query it tries to start again, and as soon as minecraft server is up the socat stays in place.

even if socat should stop for some other reasons (maybe minecraft queries not responsive etc.), my fix would just (try) to start it again, so you dont have to restart the whole world, multiple times, like someone explained in #169

sandain commented 4 years ago

I'm sorry, I still haven't had time to test this change. It looks pretty benign so I could probably just accept it, but it would be nice to have some verification that this change works. Has anyone had the chance to test it yet?