search

MinecraftServerControl / mscs

Powerful command-line control for UNIX and Linux powered Minecraft servers
https://minecraftservercontrol.github.io
BSD 2-Clause "Simplified" License
485 stars 62 forks source link

Made <port> an optional parameter for 'create' #253

Closed ScottKillen closed 4 years ago

ScottKillen commented 4 years ago

I did not also implement this on 'import' because I don't generally use it, but I can.

sandain commented 4 years ago

Hi @ScottKillen. Thanks for the patch. This change is fine with me, but it does make me worry more that there is no error checking in place for a port already in use by a different world...

ScottKillen commented 4 years ago

@sandain That is a good point, but there is also no error checking when the port is specified.

I'll see what I can do.

Would it be better to check all worlds, or only enabled worlds?

sandain commented 4 years ago

I created a new Issue (#254) for the error checking. You are right, there was no error checking prior to your patch either. I think enabled worlds should be checked for sure, disabled worlds might produce a warning rather than an error.