search

MinecraftServerControl / mscs

Powerful command-line control for UNIX and Linux powered Minecraft servers
https://minecraftservercontrol.github.io
BSD 2-Clause "Simplified" License
485 stars 62 forks source link

querySendPacket runtime optimisation #277

Closed sehnryr closed 3 years ago

sehnryr commented 3 years ago

replacing sleep 1 with a while loop that checks if the query.out is empty or not with a timeout of 1 second

sandain commented 3 years ago

This seems like a reasonable change. It appears that timeout is part of the coreutils, so there are no additional dependencies -- nice.

I don't have access to my test server at the moment (in the middle of a big move and am currently living in a hotel room), so I can't test this. If we can get an ack from @zanix or @Roflicide, I would be happy to merge this.

sandain commented 3 years ago

Thanks for testing @zanix