search

MinecraftServerControl / mscs

Powerful command-line control for UNIX and Linux powered Minecraft servers
https://minecraftservercontrol.github.io
BSD 2-Clause "Simplified" License
485 stars 62 forks source link

Created new world , now restart script don't work #284

Closed TheRanker closed 3 years ago

TheRanker commented 3 years ago

Hey guys. I had a perfectly working auto restart with a Cron job for every 8 hours on my server. Gave countdown and advised everyone of a restart commencing . Created a new world , it auto restarts it as scheduled. But immediately restarts. No prompt or anything anymore. :( My mscsctl has the proper setup and nothing changed in it. Dunno what's breaking it. Any advise is greatly appreciated. Thanks guys

zanix commented 3 years ago

If you edited the section I mentioned in msctl, can you post it here?

TheRanker commented 3 years ago

I can. And yes I did. And it worked ever since. No issues at all. Then created new worldnusing mscs create. And it don't work no more but it all remains the same

Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Joshua Clark @.> Sent: Saturday, April 10, 2021 5:04:50 PM To: MinecraftServerControl/mscs @.> Cc: TheRanker @.>; Author @.> Subject: Re: [MinecraftServerControl/mscs] Created new world , now restart script don't work (#284)

If you edited the section I mentioned in msctl, can you post it here?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/MinecraftServerControl/mscs/issues/284#issuecomment-817191989, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABM56HCRYUYBIPNOK7WOTKLTICR5VANCNFSM42WUFU5A.

zanix commented 3 years ago

Does your cron call each world separately?

mscs restart <world>

Or do you restart all of them in one command?

mscs restart
TheRanker commented 3 years ago

My Cron calls the world mscs restart NewVal33

Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Joshua Clark @.> Sent: Saturday, April 10, 2021 5:59:36 PM To: MinecraftServerControl/mscs @.> Cc: TheRanker @.>; Author @.> Subject: Re: [MinecraftServerControl/mscs] Created new world , now restart script don't work (#284)

Does your cron call each world separately?

mscs restart

Or do you restart all of them in one command?

mscs restart

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/MinecraftServerControl/mscs/issues/284#issuecomment-817198362, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABM56HFWKSQX2XG72KXQHF3TICYLBANCNFSM42WUFU5A.

TheRanker commented 3 years ago

Precious worldnis disabled

From: Joshua Clark @.> Sent: Saturday, April 10, 2021 5:59:36 PM To: MinecraftServerControl/mscs @.> Cc: TheRanker @.>; Author @.> Subject: Re: [MinecraftServerControl/mscs] Created new world , now restart script don't work (#284)

Does your cron call each world separately?

mscs restart

Or do you restart all of them in one command?

mscs restart

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/MinecraftServerControl/mscs/issues/284#issuecomment-817198362, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABM56HFWKSQX2XG72KXQHF3TICYLBANCNFSM42WUFU5A.

TheRanker commented 3 years ago 
restart | reload | force-restart | force-reload)
    # Grab the latest version information.
    updateVersionsJSON
    # Figure out which worlds to restart.
    if [ "$#" -ge 1 ]; then
      for arg in "$@"; do
        if isWorldEnabled "$arg"; then
          WORLDS="$WORLDS $arg"
        elif isWorldDisabled "$arg"; then
            printf "Unable to start the requested worlds: world '$arg' is disabled.\n"
            printf "Please enable the world first with '$PROG enable $arg'.\n"
            exit 1
        else
          printf "Unable to restart the requested worlds: world '$arg' not recognized.\n"
          printf "  Usage:  $PROG $COMMAND <world1> <world2> <...>\n"
          exit 1
        fi
      done
    else
      WORLDS=$(getEnabledWorlds)
    fi
    if [ -z "$WORLDS" ]; then
      printf "Unable to restart worlds: no enabled worlds found.\n"
      exit 1
    fi
    # Restart each world requested, start those not already
    # running.
    printf "Restarting Minecraft Server:"
    for WORLD in $WORLDS; do
      printf " $WORLD"
      if serverRunning $WORLD; then
        if [ $(queryNumUsers $WORLD) -gt 0 ]; then
          sendCommand $WORLD "say The server initiated a server auto-restart."
          sendCommand $WORLD "say The server will auto-restart in 3 minute..."
          sleep 60
      sendCommand $WORLD "say The server will auto-restart in 2 minute..."
      sleep 60
      sendCommand $WORLD "say The server will auto-restart in 1 minute..."
      sleep 60
          sendCommand $WORLD "say The server is now restarting."
        fi
        sendCommand $WORLD "save-all"
        sendCommand $WORLD "save-off"
        if [ "$(echo \"$COMMAND\" | cut -d '-' -f1)" = "force" ]; then
          forceStop $WORLD
        else
          stop $WORLD
        fi
        sleep 5
      fi
      start $WORLD
    done
    printf ".\n"
    ;;
TheRanker commented 3 years ago

my crontab

Define Home and Path

HOME=/opt/mscs PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin

Run mscs restart. remove# to activate

0 /8 mscs restart NewVal33

zanix commented 3 years ago

I hope you don't mind, but I edited your post with the script to have code tags so it's easier to read

TheRanker commented 3 years ago

restart is in 3 mins.. i just tossed ur edit into the msctl . lol

zanix commented 3 years ago

Are there any users logged into the world when it restarts? There is a line to check if there are any users first otherwise it just restarts immediately. if [ $(queryNumUsers $WORLD) -gt 0 ]; then

TheRanker commented 3 years ago

it restarts thats not hte issue. just no prompts are given

TheRanker commented 3 years ago

image

no notifications was given. :(

TheRanker commented 3 years ago

i normally have an idea what might be causing it.. but i only created a new world.. and it dont work no more :( the crontab runs it job. restarts.. but the restart script isnt prompting any notifications of restart.

pervious world with the exact same msctl prompted 3 min 2 min 1 min. and restart. .. now... nuttin. not a thing. just hard restarts.

zanix commented 3 years ago

I don't see anything wrong with your modifications, it should still work. There is some some indentation using tabs not spaces, but that shouldn't affect it.

Can you try running mscs send "say This is a test message" and see if the message shows up?

TheRanker commented 3 years ago

i can confirm that do indeed work. if i indicate which world im sending it to ;)

zanix commented 3 years ago

Well dang, that's the exact same command that outputs the messages. Maybe the tabs vs spaces does matter? Although it should matter, might as well try changing those tabs to spaces.

Also, you can send to all active worlds using mscs broadcast <command> if you wanted to.

TheRanker commented 3 years ago

it worked before.. perfectly.. never got edited changed or modified in any way at all. but will not work on my new world.

commands work. thats not an issue.

zanix commented 3 years ago

You created a new world, that is the difference. I wanted to check if a simple send command worked and that a test message would show up on this new world.

Just so I have this correct, if you run mscs restart NewVal33 it restarts in 3 minutes but has no prompts in-game? Does the the restart process, plus messages, work on another world?

TheRanker commented 3 years ago

root@vmi527064:~# mscs restart NewVal33 find: Failed to restore initial working directory: /root: Permission denied The cached copy of the version manifest is up to date. Use the force-update option to ensure a new copy is downloaded. Restarting Minecraft Server: NewVal33

TheRanker commented 3 years ago

finally an error that could be used to resolve it. ran with sudo too.. permission denied.

server never restarted.. it saved an stopped.. but never started back up

with the crontab and using restart... it do successfuly start back up

alsoo i ve stated 3 times already... Just so I have this correct, if you run mscs restart NewVal33 it restarts in 3 minutes but has no prompts in-game? NO prompts are given.. HArd restart... no 3 mins.. no nothing.. just a HARD restart at the scheduled time

TheRanker commented 3 years ago

find: Failed to restore initial working directory: /root: is the main cause of all of this.

zanix commented 3 years ago

Well dangit. I have to go in a few minutes so I won't be able to help. One last thing I can think of, revert your changes and copy the msctl script from where you downloaded it to /usr/local/bin/, then try the restart command again.

As for the find command error, I'm not sure what that means.

Sorry I couldn't help fix it before I leave for the weekend.

TheRanker commented 3 years ago

im not reverting any changes man.. 30 palyers on this server

zanix commented 3 years ago

I'm just talking about the changes the msctl script. Did you make other changes to it?

TheRanker commented 3 years ago

i never made ANY CHANGES.. NONE

TheRanker commented 3 years ago

did i make any other changes??? i never made a change yet ffs.

zanix commented 3 years ago

No need to get upset.

You added those additional sleep and sendMessage commands in the restart | reload | force-restart | force-reload section of the msctl script. I was just suggesting that you copy over the original msctl script and try that to see if it worked with the prompts, although it would be only a 1 minute warning instead of 3.

I am sorry I am not able to help any further. I will check back when I get home in a few days.

TheRanker commented 3 years ago

ive added thaty month ago man maybe you should get some facts strigth before you suggest somethign Havent edited the damn thing in over 3 weeks.... worked perfect.... created new world

now it dont pompt and force hard resest

notign was change.d. nothign was editted.. nothin was modified.

new world created and loaded. .. dats it.

TheRanker commented 3 years ago

i went and re-assigned a chown for minecraft:minecraft... for the resposatory i downloaded 4 weeks ago... and the current mscs folder its operating out of. ... didnt resolve anything.

TheRanker commented 3 years ago

and zanik .. i also downloaded and installed your msc-gui ... all done and on the system.. no clue how to run it, view it.. see it, ,, operate it,, comamnd it... nothing . not a stitch of info anywhere on what to do with the thing onces you run your little install. right now its sitting on the server.. doing nothing. cause no documentation on how to use it, or even what to do with the bloody thing once its installed. pretty sad man. Updated on Mar 6, 2016 given its been 5 years now and you didnt even include any help in using the bloody thing? its useless.

zanix commented 3 years ago

Sorry, here are the docs https://minecraftservercontrol.github.io

The link is kinda hidden on the main repo page

TheRanker commented 3 years ago

Sorry, here are the docs https://minecraftservercontrol.github.io

The link is kinda hidden on the main repo page

Ummm. U have no useage direction of that service. No commands no idea how to run it or what to do with it. U have installation and info of what it's for... Nothing to do with it after installation. .

zanix commented 3 years ago

I didn't notice you said mscs-gui, I thought you were talking about the mscs script only. mscs-gui is not in a complete state so there is no documentation and there haven't been much interest in it either.

TheRanker commented 3 years ago

I'll most on that GitHub for advice. But this mscs restart isn't giving notifications. Cause it says the initial folder has no permissions. But damn thing works. Just not properly. Make a uninstall and reinstall will fix. But I don't know how to do that with mscs on Ubuntu 20.04

Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Joshua Clark @.> Sent: Sunday, April 11, 2021 3:26:06 PM To: MinecraftServerControl/mscs @.> Cc: TheRanker @.>; Author @.> Subject: Re: [MinecraftServerControl/mscs] Created new world , now restart script don't work (#284)

I didn't notice you said mscs-gui, I thought you were talking about the mscs script only. mscs-gui is not in a complete state so there is no documentation and there haven't been much interest in it either.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/MinecraftServerControl/mscs/issues/284#issuecomment-817346338, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABM56HDXIUBIW24VELOPNPDTIHPDNANCNFSM42WUFU5A.

zanix commented 3 years ago

cd into the directory where you cloned/downloaded the script and run sudo make clean, that should remove the files

TheRanker commented 3 years ago

And just do the get clone part again after? Don't need to do the full setup or anything ? As the clone isn't in the same folder as mscs is running from

Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Joshua Clark @.> Sent: Sunday, April 11, 2021 3:34:46 PM To: MinecraftServerControl/mscs @.> Cc: TheRanker @.>; Author @.> Subject: Re: [MinecraftServerControl/mscs] Created new world , now restart script don't work (#284)

cd into the directory where you cloned/downloaded the script and run sudo make clean, that should remove the files

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/MinecraftServerControl/mscs/issues/284#issuecomment-817347613, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABM56HB6EXSQCHSMRLQT7NDTIHQD5ANCNFSM42WUFU5A.

zanix commented 3 years ago

Correct, you would just be re-installing the script files from the folder where you downloaded the script. The /opt/mscs folder is your data folder. The makefile copies the script files to /usr/local/bin and some other files elsewhere, you can see what it does in the Makefile https://github.com/MinecraftServerControl/mscs/blob/main/Makefile

Looking the makefile closer, I think you could just run sudo make update and that should re-copy the files again.

TheRanker commented 3 years ago

Ok. So the repo I've downloaded before was in home/theranker/Minecraft. And opt/mscs. And in the /use/bin.

Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Joshua Clark @.> Sent: Sunday, April 11, 2021 3:43:30 PM To: MinecraftServerControl/mscs @.> Cc: TheRanker @.>; Author @.> Subject: Re: [MinecraftServerControl/mscs] Created new world , now restart script don't work (#284)

Correct, you would just be re-installing the script files from the folder where you downloaded the script. The /opt/mscs folder is your data folder. The makefile copies the script files to /usr/local/bin and some other files elsewhere, you can see what it does in the Makefile https://github.com/MinecraftServerControl/mscs/blob/main/Makefile

Looking the makefile closer, I think you could just run sudo make update and that should re-copy the files again.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/MinecraftServerControl/mscs/issues/284#issuecomment-817349002, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABM56HFTJ2JPNPLT6ZYRNYLTIHREVANCNFSM42WUFU5A.

sandain commented 3 years ago

@TheRanker: @Zanix and myself are not paid to help you. You have paid nothing for the work we have done. Your attitude is unwanted. MSC-GUI is a Proof -Of-Concept and is not meant for production servers.

I'm closing this issue as not our bug. User error.

sandain commented 3 years ago

I've banned @TheRanker from commenting for 7 days. Additional abuse beyond that period will result in a permanent ban. I will not put up with this kind of abuse.