search

MinecraftU / 2021-computer-adventures

Repository for our 2021 Computer Adventures Ruby project!
0 stars 0 forks source link

Collision detection #30

Closed jamespeilunli closed 3 years ago

jamespeilunli commented 3 years ago

This has a bug where in tetris.rb the gameboard matrix is blank.

jamespeilunli commented 3 years ago

still messy

dealingwith commented 3 years ago

Looking better, though. My only feedback so far would be that you're keeping gameboard_width and height in two places...

dealingwith commented 3 years ago

Also you've implemented some of the refactorings I worked on yesterday, which is great. I think we should get this into a mergable state and then work on any refactoring/improvements in a separate PR.

dealingwith commented 3 years ago

you're keeping gameboard_width and height in two places

and size

I'm going to resolve the conflicts in this branch and then work on that minor bit of refactoring...