MinecraftWars / Gringotts

Item based economy plugin for Bukkit
BSD 2-Clause "Simplified" License
37 stars 76 forks source link

Vaults are broken #170

Closed quiquelhappy closed 5 years ago

quiquelhappy commented 6 years ago

Vaults are not working, also, the deposit or withdraw methos are not working either. Could someone fix this please?

ghost commented 6 years ago

Same here, running Minecraft 1.13

Get a message saying that the emeralds were added, but they are just turned into blocks in my inventory, and the amount is still 0.

Same adding emeralds as an admin, says the emeralds are added, but the /money command still shows 0.

ttocsneb commented 5 years ago

I have found that vaults/enderchests do work; the issue is with how gringotts interprets your inventory. I think your inventory is considered to be a vault which allows it to be used in transactions and show in the /money command.

When you run the command /money withdraw X, X amount of emeralds will be sent to your inventory from one of your vaults as it should. However, when you run the command /money deposit X, X amount of money is deposited into a vault, it's just that it treats your inventory as a vault, so it will be taken out of your inventory, then put back into your inventory. Which is why it will be changed into blocks.

I don't know anything about how gringotts works under the hood, but I bet that if it were to somehow not treat the player's inventory as a vault when depositing, the issue might be resolved.

bundabrg commented 5 years ago

Duplicate of #164