Closed bundabrg closed 5 years ago
Thanks! Was there a reason to remove the static imports? I think removing WG6.2 support for newer releases is reasonable. But up to you and current maintainer :)
It will mean dropping pre 1.13 support. Wasn't sure on what policy here. For betonquest I try support all versions because heaven help the 1 person still running 1.8 Minecraft not getting updates :)
From my POV the policy is whatever current maintainers want, because I haven't been working on Gringotts for years. Maybe @nikosgram13 has an opinion. Otherwise I'm happy to give you the appropriate access rights to be a maintainer if you want.
Happy to be a maintainer. I'll wait for which option is best though since I don't know what Gringotts target audience it yet. I run all 1.13.2 servers so either option works for me.
Updated to remove all the unnecessary changes. I'll blame my IDE settings for it.
Can you update to make it compatible with the other merged PR?
It was an either/or thing. Either just merge the other one (which ONLY supports WG 7.0.0) or this one which supports both 7.0.0 and 6.2
Right, sorry, I confused this one with the Factions one.
Changes
Closes
Closes #186
Notes
An alternative (and simpler method) is to drop support for WG 6.2 and only support 7.0.0. That's a fairly trivial change. Otherwise to support both requires a multi-module maven setup as done here.