Provide better support for detecting Factions

MinecraftWars / Gringotts

Item based economy plugin for Bukkit

BSD 2-Clause "Simplified" License

37 stars 78 forks source link

Provide better support for detecting Factions #188

Closed bundabrg closed 5 years ago

bundabrg commented 5 years ago

Changes:

Test for factions using the class com.massivecraft.factions.TerritoryAccess. This avoids issues with a fork of factions (SavageFaction) causing Gringotts to fail entirely

jastice commented 5 years ago

Thanks! I think the softdepend needs to be removed

bundabrg commented 5 years ago

I'll take out the soft depends. Does it handle the case if factions loads afterwards?

I may also add a pr to directly support Savage factions as an accountprovider since it seems to be one of the few 1.13 plugins.

jastice commented 5 years ago

I don't really remember if or how it needs to handle Factions loading afterwards. I think Gringotts would always load before because of loadbefore: [Vault] and Factions would depend on Vault. And IIRC this was the reason to use the classpath check for gringotts dependencies since it doesn't depend on those plugins being loaded? I forgot.

bundabrg commented 5 years ago

soft-dependency removed. It compiles and seems to work on my test server (where previously running SavageFactions cause both SF and Gringotts to entirely fail to load). I don't actually run SF myself, this was just a request from someone else.