search

MinecraftWars / Gringotts

Item based economy plugin for Bukkit
BSD 2-Clause "Simplified" License
37 stars 76 forks source link

Issue with /money pay 100 <playername> #197

Closed lvavila closed 4 years ago

lvavila commented 5 years ago

Shows 0 payed to playername with no other action. Using 1.13.2 now. Everything else works fine. Love plugin, hope it continues with 1.14. Diamonds:$100 quartz:$10

VaiTon commented 5 years ago

Duplicate of #193.

lvavila commented 5 years ago

Observation in code (GringottsAbstractExecutor)

Does this transaction complete successfully if taxes are disabled?

TransactionResult result = playerAccount.send(value).withTaxes().to(eco.player(recipientName)); Obviously a SUCCESS is being passed back but formattedValue is 0.00.

VaiTon commented 5 years ago

Even if it doesn't complete successfully and the returned value is SUCCESS the formattedValue should be the same as the parameter value. (See this line)

I'm going to investigate this.

lvavila commented 5 years ago

Thanks for the attention. I hope you move forward with 1.14 support for if you do I will contribute either through donations or code additions to your project as I am a professional C# developer aspired in having Java in my tool belt. As a new survival 1.13.2 server owner, I find your project different and motivating.

jastice commented 5 years ago

Thanks for looking into it, @lvavila Code contributions and fixes are very welcome

flanigomik commented 5 years ago

this is still an issue with the 1.14 build, somebody else linked a 1.13 compatible build here; https://github.com/bundabrg/Gringotts/releases/tag/v3.0.0-preview.1 love the plugin but it is useless without being able to pay people.