Closed TheFlagCourier closed 3 years ago
Thanks. I'll have a look tomorrow.
Thanks for this! I'll let @nikosgram review and merge if he's still around ;)
Remove zno.de repository and deployment scheme - Would run into HTTP 502 errors.
Probably because only I have the deployment keys. But if Jitpack works fine for this, no need to keep it around. I remember I had manually deployed some dependencies to repo.zno.de, maybe we can find an alternative for this as well?
Thanks for this! I'll let @nikosgram review and merge if he's still around ;)
Remove zno.de repository and deployment scheme - Would run into HTTP 502 errors.
Probably because only I have the deployment keys. But if Jitpack works fine for this, no need to keep it around. I remember I had manually deployed some dependencies to repo.zno.de, maybe we can find an alternative for this as well?
I'm in no rush, so sounds good. Again, I don't personally use Gringotts, so if anyone sees something out of the ordinary, let me know.
Yeah, makes sense if the repository is locked away. If there is a need to manually deploy, then maybe using the GitHub Package Registry would be a good static replacement? Jitpack can be finicky to work with, especially with a lack of recent release tags and as dependencies decay over time.
GitHub Package Registry sounds like a good idea. It wasn't around way back when.
Looks good so far but I'll just need to test on my server properly. Will get back soon.
Github package registry requires an account to read from so I tend to avoid it. I'm happy to provide deployment keys to my registry at https://repo.worldguard.com.au/ if you like @jastice otherwise jitpack isn't too bad generally.
shall we just merge this?
@jastice It can be merged for current Towny compatibility. As a heads-up though, there are plans to nuke the Towny EconomyException (https://github.com/TownyAdvanced/Towny/pull/4806)
Edit: After rechecking the TownyHandler class, this exception isn't caught anyways.
Thanks!
The primary goal of this PR was to fix (or at least give a foundation to fix) issues with the Towny integration. However, I sort of let it get away from me and ended up tackling more than that...
Dependency Updates
Fixes
Deprecation & Removals
Funding
file: Not enabled on this repository, repo has no active maintainers.Documentation
Pending Changes
entry to log changes to, prior to a tagged release.Maven/Gradle repo
section asDepending on Gringotts
in the README