search

MinecraftWars / Gringotts

Item based economy plugin for Bukkit
BSD 2-Clause "Simplified" License
37 stars 77 forks source link

vault destroyed #53

Closed Nekuroi closed 11 years ago

Nekuroi commented 11 years ago

Everytime someone creates a vault the previous get destroyed

Plugins: Orebfuscator, GroupManager, NoCheatPlus, WorldEdit, Multiverse-Core, BanHammer, CombatTag, Questioner, Gringotts, WorldGuard, UberForest, BloodMoon, TreeAssist, AntiJoinBot, RemoteToolkitPlugin, dynmap, OpenInv, Lockette, Essentials, Towny, EssentialsSpawn, VanishNoPacket, Vault, xAuth, ChestShop, TownyChat, Dynmap-Towny

Spigot-377 (Implementing API version 1.4.6-R0.4-SNAPSHOT) gringotts 1.5 vault 1.2.22-b277

14:43:59 [INFO] [Gringotts] storing account chest: [vault] 22, 65, 296, CraftWorld{name=imperium} for account: Account (PlayerAccountHolder(Nekuroi))
14:44:10 [INFO] [Gringotts] Destroying orphaned vault: [vault] 22, 65, 296, CraftWorld{name=imperium}
14:44:10 [INFO] [Gringotts] storing account chest: [vault] 23, 65, 302, CraftWorld{name=imperium} for account: Account (org.gestern.gringotts.accountholder.TownyAccountHolder@137554fc)
14:45:33 [INFO] [Gringotts] Destroying orphaned vault: [vault] 23, 65, 302, CraftWorld{name=imperium}
14:45:33 [INFO] [Gringotts] storing account chest: [vault] 37, 65, 304, CraftWorld{name=imperium} for account: Account (PlayerAccountHolder(Zhren))
jastice commented 11 years ago

Thanks for the report!

Does this happen with any Vault type, or only with Towny? Can you please check if the issue is present if you downgrade to Gringotts v1.4.2?

Thanks!

Nekuroi commented 11 years ago

Yes, happens with any vault type and occur the same with the 1.4.2 version.

jastice commented 11 years ago

Okay, that's awkward. Would you mind zipping up your server setup (without the world files) and sending it to me at jast@zno.de ? I'll try to reproduce it.

Nekuroi commented 11 years ago

Is very annoying, in the v1.4.1b this doesn't occur. I tried it with the official bukkit versions 1.4.6 0.1 0.3 and 0.4 and i get the same issue. Maybe a problem with java?

btw sending mail~

jastice commented 11 years ago

Great, thanks for isolating the issue! It's probably a Gringotts problem. I'll see what I can do.

bezeek commented 11 years ago

I'm having this same issue with 1.5.0 from Bukkit. AFAIK, it occurs because the vault title is made bold and no longer passes the Valid() check.

On a similar note, making the title bold pushes "[Faction Vault]" past the 15-char limit, and so it's truncated and fails the Valid() check.

Looks to me like the culprit isn't synced to Git yet - a fresh compile from here did not bold my vault titles.

jastice commented 11 years ago

Thanks a lot for finding this! I'll fix it right away (and push)

jastice commented 11 years ago

Here's the update to 1.5 in code: https://github.com/MinecraftWars/Gringotts/tree/v1.5.x and as jar: http://dev.bukkit.org/server-mods/gringotts/files/18-gringotts-v1-5-1/

Please let me know if any other problem turns up with this version!

bezeek commented 11 years ago

Normal vaults are working properly now. Faction vaults are no longer bold, and do not self-destruct. However, Factions (1.8.0) always returns a zero balance and deposits are lost in the ether.

jastice commented 11 years ago

Programming is a constant slap in the face by reality, reminding me that I'm not that smart ... I'm on it.

jastice commented 11 years ago

I should have really released 1.5.0 as beta ... here we go: http://dev.bukkit.org/server-mods/gringotts/files/19-gringotts-v1-5-1a/

Update is also pushed to 1.5.x branch

(next major release will also be actually tested)