stephan-gh
commented
3 years ago Hm, apparently I never replied here. Sorry. Basically, I had a couple of concerns here:
- This is not (properly) backwards compatible: MiniMessage does not handle legacy color codes, so old configurations would not be valid anymore. (It works somewhat because the MC client still interprets raw color codes like
§c, but they cause very weird issues now...) - The extra dependency on MiniMessage and the entire Adventure API increases the size of the ServerListPlus JAR. Also, I'm not sure how to integrate this into SLP's (rather convenient) universal JAR given that many APIs (e.g. Paper, Velocity, Sponge) now provide Adventure by default but only on newer versions.
- The main advantage of MiniMessage would be to use all kinds of the newer chat component features (e.g. hover actions, click actions, ...) but as far as I know those cannot be used in the server list.
As far as I understand the main motivation of this PR was just to provide support RGB colors. Support for RGB colors already exists in Bukkit and BungeeCord natively, without using some other libraries as I just described in https://github.com/Minecrell/ServerListPlus/issues/295#issuecomment-832716101. So, I have made use of the native support for RGB colors, built a bit of convenience around it (e.g. a nicer color code format, a gradient placeholder). This should be fairly equivalent to what is possible with this PR, but better integrated into SLP, fully backwards compatible and some other advantages.
This was done by @darbyjack as a third party for Alerium; and I figured guys would benefit from this.