Minecrell / ServerListPlus

A flexible Minecraft plugin to customize the appearance of your server in the server list
https://git.io/slp
GNU General Public License v3.0
240 stars 58 forks source link

Incompatible version with 1.20.4 (likely ProtocolLib issue, Paper is not affected) #406

Closed SlimeDog closed 9 months ago

SlimeDog commented 9 months ago

Spigot 1.20.4-3966 ServerListPlus 3.5.1-b537

Vanilla MC client 1.20.4

Client cannot connect to remove server. Client log states: Can't ping Client hover shows "Incompatible version"

stephan-gh commented 9 months ago

Can you post the configuration or does it happen with any? Any error in the log?

SlimeDog commented 9 months ago

ServerListPlus.yml, comments elided

--- !Status
Default:
  Description:
  - |-
    &f &l{server_name}&r &f▪ {server_variant} {server_version_full}&r &f▪ private network&r
    &r &6⊳&r&aCityWorld &6⊳&r&aExtraHard &6⊳&r&aGoT &6⊳&r&aLuckyBlock &6⊳&r&aSkyBlock &6⊳&r&aWinterland&r
  Players:
    Hover:
    - |-
      &aWoof! Woof!
      &aWho let the dogs in?
  Favicon:
    Folders:
    - ../../
Personalized:
  Description:
  - |-
    &f &l{server_name}&r &f▪ {server_variant} {server_version_full}&r &f▪ private network&r
    &r &6⊳&r&aCityWorld &6⊳&r&aExtraHard &6⊳&r&aGoT &6⊳&r&aLuckyBlock &6⊳&r&aSkyBlock &6⊳&r&aWinterland&r
  Players:
    Hover:
    - |-
      &aWoof! Woof!
      &aWho let the dogs in?

--- !Plugin
PlayerTracking:
  Enabled: false
  Storage: !JSONStorage
    Enabled: false
    SaveDelay: 5m
StripRGBIfOutdated: true
Unknown:
  PlayerName: player
  PlayerCount: ???
  Date: ???
  BanReason: some reason
  BanOperator: somebody
  BanExpirationDate: never
Favicon:
  Timeout: 10s
  RecursiveFolderSearch: false
  ResizeStrategy: SCALE

--- !Bukkit
ProtocolLib: ENABLE
SlimeDog commented 9 months ago

No log errors.

$ grep ServerListPlua logs/latest.log 
[07:42:16] [Server thread/INFO]: [ServerListPlus] Loading ServerListPlus v3.5.1-SNAPSHOT
[07:43:10] [Server thread/INFO]: [ServerListPlus] Enabling ServerListPlus v3.5.1-SNAPSHOT
[07:43:10] [Server thread/INFO]: [ServerListPlus] [Core] Reloading configuration...
[07:43:10] [Server thread/INFO]: [ServerListPlus] [Core] Loaded configuration: ServerStatusConf
[07:43:10] [Server thread/INFO]: [ServerListPlus] [Core] Loaded configuration: PluginConf
[07:43:10] [Server thread/INFO]: [ServerListPlus] [Core] Loaded configuration: BukkitConf
[07:43:10] [Server thread/INFO]: [ServerListPlus] Successfully loaded!
[07:43:10] [Server thread/INFO]: [ServerListPlus] ServerListPlus v3.5.1-SNAPSHOT enabled.
[07:43:11] [Server thread/INFO]: ServerListPingEvent: Spigot iterator API
[07:45:09] [Server thread/INFO]: [ServerListPlus] [Core] Cleaning favicons cache...
[07:45:09] [Server thread/INFO]: [ServerListPlus] Successfully cleaned up favicons cache.
[07:45:09] [Server thread/INFO]: [ServerListPlus] Reloading configuration...
[07:45:09] [Server thread/INFO]: [ServerListPlus] [Core] Reloading configuration...
[07:45:09] [Server thread/INFO]: [ServerListPlus] [Core] Loaded configuration: ServerStatusConf
[07:45:09] [Server thread/INFO]: [ServerListPlus] [Core] Loaded configuration: PluginConf
[07:45:09] [Server thread/INFO]: [ServerListPlus] [Core] Loaded configuration: BukkitConf
[07:45:09] [Server thread/INFO]: [ServerListPlus] Configuration successfully reloaded!
[07:45:09] [Server thread/INFO]: [ServerListPlus] Enabling ServerListPlus...
[07:45:09] [Server thread/INFO]: [ServerListPlus] No changes. ServerListPlus is already enabled!
SlimeDog commented 9 months ago

ProtocolLib 5.1.1-SNAPSHOT-673

If in ServerListPlus.yml

ProtocolLib: DISABLE

SLP works, but in the log

[08:05:21] [Server thread/WARN]: [ServerListPlus] ProtocolLib IS NOT ENABLED! Most features will NOT work! Alternatively, consider using Paper for full functionality without ProtocolLib!

The hover text is not visible in the client, but I can live with that until Paper is available. Any other negative consequences?

Better: please support the newer ProtocolLib and Spigot 1.20.4.

stephan-gh commented 9 months ago

I can reproduce the problem but I suspect it's a ProtocolLib issue. SLP really just uses the API provided by ProtocolLib in the same way that it uses e.g. the Paper API. I'll need to check inside ProtocolLib if I can find the problem.

Paper builds are out now and those are not affected, so I would recommend using Paper for full functionality until we figure this out.

stephan-gh commented 9 months ago

The hover text is not visible in the client, but I can live with that until Paper is available. Any other negative consequences?

No, with ProtocolLib disabled on Spigot the functionality is simply limited - certain features of SLP won't work. There are no other negative consequences. On Paper everything works also without ProtocolLib because it exposes more features in the API.

SlimeDog commented 9 months ago

Thanks. ProtocolLib supports 1.20.4 now, so I expect that all is well.