search

Minehut / MinehutBOT

GNU General Public License v3.0
16 stars 19 forks source link

Remove trailing comma #136

Closed DebitCardz closed 3 years ago

Sniped commented 3 years ago

I don't see the point in removing the trailing comma here. The formatter that is used for the project, Prettier, actually adds these by default, so if we were to remove the trailing comma here, we would probably have to remove the trailing commas everywhere in the codebase, which would mostly be prominent in guildConfigs.ts. A few examples of this are shown here, here, and here.

DebitCardz commented 3 years ago

I don't see the point in removing the trailing comma here. The formatter that is used for the project, Prettier, actually adds these by default, so if we were to remove the trailing comma here, we would probably have to remove the trailing commas everywhere in the codebase, which would mostly be prominent in guildConfigs.ts. A few examples of this are shown here, here, and here.

prettier wack.

jellz commented 3 years ago

What’s the purpose of this PR?

DebitCardz commented 3 years ago

What’s the purpose of this PR?

to remove a trailing comma as said in the title.