MinerAp / radio

A Bukkit plugin recreating the radio functionality from Cake's Miner Apocalypse
http://dev.bukkit.org/bukkit-plugins/radio/
GNU General Public License v3.0
0 stars 0 forks source link

Radio Range Issue #4

Open ghost opened 11 years ago

ghost commented 11 years ago

Using Radio plugin version 1.15.0 on craftbukkit-1.6.4-R0.1-20130920.192319-3.jar

The radio tower I have contains two diamond blocks at the base, and a vertical tower of 170 Iron Bars. At the top of the transmitter (mainly to make it look cool) is a set of glowstone and RedWool blocks. The tower is at X9, Y7, Z104

I went to the top of my tower, with the radio turned on and tuned. Just before I reached the top, I stopped receiving signals entirely for about five minutes.

When signals resumed, I decided to test the range, and moved my player to X-315, Y172, Z113. At this position, with the radio tower being 171 tall, and having a diamond block, I should be receiving a clear radio signal, but instead I receive no signal at all.

I tested whether the additional un-needed Diamond Block was interfering with the function of the radio, but after changing that to an Iron Bar, nothing changed. I tried destroying the part of the top of the tower (glowstone and Red Wool) to see if that made any difference, also to see no change at the distance from the tower that I was at.

I have not modified the config since default generation, and am feeling unsure on why I'm not receiving signal at the range I am at, since if the size increase was stable 30 (default value) than at 170, the tower range is 5100 blocks. Being less than 500 blocks away, I get no signal and don't understand why.

After disconnecting and reconnecting, I started to receive signals, but after moving about 10 blocks further out, signals ceased again.

I've linked three images of the radio tower I have (top half, bottom half and the base transmitter station) so that you can see for yourself whether I am doing anything wrong.

http://img545.imageshack.us/img545/1796/gyl2.png http://img163.imageshack.us/img163/5306/7z5f.png http://img585.imageshack.us/img585/2991/3rqa.png

Is this something I am doing, or a bug with the plugin? Thanks BAI1

indiv0 commented 11 years ago

First off, I LOVE your design. That's beautiful.

Secondly, while reading through your description, the first, and obvious possible cause of the malfunction was the double diamond blocks. That does indeed not work. You said you removed it an replaced one with an iron bar, which is indeed the correct procedure.

However, for the radio to re-register the construction correctly, I believe you need to break the jukebox and cut power, and recreate the jukebox and power it again.

Try that and let me know how it goes.

ghost commented 11 years ago

Thanks for the design compliments.

I did as you said, replacing the Diamond Block with an Iron Bar, and then reconstructing the radio and power source. The signal didn't stop when I reached the top of the tower, so I proceeded to head in the same direction that I had done before. Being at X-286, Y63, Z121 was where signal cut out, Doing the math, I am (at that position) I am about 350 blocks from transmitter. If I move one block closer to the transmitter (Changing the X to -285) I regain signal. If I move back out that one block, signal dies out again.

I tested something as a spark of the moment thought, and removed any clarification blocks (So, no Diamond/Iron/Lapis/Gold Blocks). After doing that and rebuilding the radio block again, I found that I had clear signal at almost any range on the map (up to tested 1000-1500 blocks, still testing).

Thanks for the suggestion as well. While it didn't do anything, it led me to test this which in turn got it working, however (from the results) I believe it may have exposed a bug with the clarity blocks and transmission range. I will be testing the other clarity blocks to see if any of them work as well. BAI1

ams2990 commented 11 years ago

After changes, from lowest to highest, what is the order of your blocks? 

ghost commented 11 years ago

"After changes, from lowest to highest, what is the order of your blocks?"

Lever on the bottom for power, Jukebox with signs on it, Iron Bars all the way up for 172 blocks, until that RedWool and Glowstone top part for decoration. No signal enhancers or clarification devices, just the Iron Bars. BAI1

ams2990 commented 11 years ago

172 blocks will give you quite a bit of range. What happens if you swap out the bottommost iron bar for a diamond block? 

-------- Original message -------- From: BAI1 notifications@github.com Date: 10/14/2013 11:12 AM (GMT-05:00) To: Indiv0/radio radio@noreply.github.com Cc: ams2990 andy.shulman@hotmail.com Subject: Re: [radio] Radio Range Issue (#4)

"After changes, from lowest to highest, what is the order of your blocks?"

Lever on the bottom for power, Jukebox with signs on it, Iron Bars all the way up for 172 blocks, until that RedWool and Glowstone top part for decoration. No signal enhancers or clarification devices, just the Iron Bars. BAI1

— Reply to this email directly or view it on GitHub.

ghost commented 11 years ago

"172 blocks will give you quite a bit of range. What happens if you swap out the bottommost iron bar for a diamond block?"

Similar to before, replacing the base block above the Jukebox with a Diamond Block at about 350 blocks away I lose signal entirely, with small portions of signal degradation at about 310-320 blocks. Replacing the recently placed Diamond Block at the bottom to an Iron Bar again restores full strength. With these results, I feel the plugin may not be detecting the Diamond Block, or may be considering it a range increment block rather than a signal quality multiplier block. BAI1

ams2990 commented 11 years ago

@Indiv0, you broke the search going up the radio tower when you refactored the block. 

indiv0 commented 11 years ago

Thanks, @ams2990.

ghost commented 10 years ago

Issue is still present in 1.16.0, I was having issues receiving signal at the top of my 192 tall tower while using a single diamond block at the base, however removing that block removed all range issues. ~BAI1

indiv0 commented 10 years ago

I guess the jar on BukkitDev is outdated. I'll get around to updating it soon.

In the meantime, try putting these two jars into your jar/ directory. That's the absolute latest version of Radio.

Let me know what happens.

ams2990 commented 10 years ago

Putting mbapi into the plugins directory is going to fail to load. He needs to use a shaded version. @BAI1, what version of Minecraft are you running?

indiv0 commented 10 years ago

Right. I haven't done this in so long I forgot how to include mbapi to the classpath :P

Let me compile a shaded version.

indiv0 commented 10 years ago

https://github.com/MinerAp/radio/releases/download/v1.16.0/radio-1.20.0-shaded.jar

There you go.

ghost commented 10 years ago

Error with mbapi-1.20.jar while loading @ http://pastebin.com/d1HP5mYh And an error with radio-1.20.0-shaded also while loading @ http://pastebin.com/WNmXdNRr

Swapping out radio-1.20.0-shaded.jar with radio-1.20.0.jar caused a much larger error, one which directly referenced mbapi. http://pastebin.com/8F0dfsRs None of the downloads worked. Minecraft 1.7.2 btw. ~BAI1

indiv0 commented 10 years ago

@BAI1 right, as ams2990 said, putting mbapi into the plugins directory will fail to load. Delete mbapi-1.20.jar but leave radio-1.20.0-shaded.jar in the plugins directory.

indiv0 commented 10 years ago

Nvmd. Pretty sure this is because of this Bukkit PR being fixed.

Update your Minecraft server to Bukkit version at least Bukkit 1.7.9-R0.3.

ghost commented 10 years ago

Updating to 1.7.9 would be a global server update, although on the test server (cauldron-1.7.10-1.1187.01.127-server.jar) the plugin loaded fine. Couldn't actually join my own test server to test if its fixed (likely due to the fact I am using Cauldron, a Forge+Bukkit file).

Testing with craftbukkit-1.7.9-R0.3-20140603.002405-1.jar caused this error: http://pastebin.com/pw8tvGgG For safety, I also tested using the Beta build R0.2, error is as follows: http://pastebin.com/GvyZ0v3E ~BAI1

ghost commented 10 years ago

Plugin seems to have loaded despite the errors, however commands only register the /radio part, and do not act upon the rest of the command (EG: "/radio tune 1.0" does nothing except show standard command usage). ~BAI1

indiv0 commented 10 years ago

Try a later version. That version doesn't appear to have the fix implemented.

ghost commented 10 years ago

Issue does seem fixed using craftbukkit-1.7.9-R0.3-20140705.002733-4.jar and Radio-1.20.0.jar ~BAI1

indiv0 commented 10 years ago

Alright good to hear. Sorry that you need to do a global update. Blame Bukkit :P

I'll leave this open until I update the BukkitDev page with the new download.