Where should I export the interface functions?

MineralsCloud / Express.jl

Express: a high-level, extensible workflow framework for accelerating ab initio calculations for the materials science community

https://mineralscloud.github.io/Express.jl/

GNU General Public License v3.0

25 stars 1 forks source link

Where should I export the interface functions? #53

Closed singularitti closed 3 years ago

singularitti commented 3 years ago

In commit ["a975d2aaf7314e3c1cbb82413686e46cee4f374a"]() I remove all exports in EosFitting.jl & Phonon.jl. But after reading "Development with Interface Packages", maybe I should not do that? Because Express.jl should be an interface package and QuantumESPRESSOExpress.jl, etc., should just implement it? Like

using Express.Phonon: buildworkflow
using QuantumESPRESSOExpress.Phonon

rather than

using QuantumESPRESSOExpress.Phonon: buildworkflow