Mines-Paristech-Students / Portail-des-eleves

The Mines Paristech's student life management application
23 stars 6 forks source link

Delmaass/marketplace #318

Closed delmaass closed 2 years ago

delmaass commented 3 years ago

The goal of this PR is to fix every issues about marketplace and library, then to add a marketplace subscription system - a feature asked by the Biero association - which can have an impact on the price you pay a product in a marketplace.

Bug fixes

Subscription feature

A marketplace administrator can modify the subscriber status of an user. The new subscriber can then have prices advantages in the shop.

The subscriber status is indicated next to the user's balance. marketplace-when subscriber marketplace-when-not-subscriber

The correct price is taken into account in the Transaction. order_subscriber

It is optional to add a subscriber price to a product. add-product table_products

delmaass commented 3 years ago

I don't understand why Django CI check is raising ERROR: associations.tests.event.test_calendar (unittest.loader._FailedTest) whereas I started this branch before the addition of the Calendar feature. Any ideas how to going through this test ?

delmaass commented 3 years ago

I also don't understand why npx prettier --write frontend works locally with successful checks npx prettier --check frontend with prettier@2.0.5 (the version used in the Git test) but the check fails...

abocquet commented 3 years ago

For the failing CI, try to merge master into your branch

abocquet commented 3 years ago

Hello, first of all thank you for you work , seems great! However your PR is pretty big (1000+ lines), so if you want to get relevant feedback, I suggest you split it up into smaller PRs. A simple way to do it is to open 1 PR by fixed issue you mention above :)