search

Mineshopper / carpentersblocks

A Minecraft mod.
GNU Lesser General Public License v2.1
133 stars 82 forks source link

[Render Bug][ISBRH]Carpenters' blocks causing odd render issues #263

Open ReikaKalseki opened 9 years ago

ReikaKalseki commented 9 years ago

For some reason, putting some Carpenters' blocks - particularly the torch - causes my pipe renderer to glitch, in the form of flipping some of its connections.

Breaking the carpenters' blocks fixes the issue.

My best guess is that something in the Carpenters' ISBRH is flipping an axis or something, but obviously you would know better than I do.

Mineshopper commented 9 years ago

Trying to get RotaryCraft loaded (it has those pipes, right?), but crashes saying some classes are missing: http://pastebin.com/CddVyzWU

ReikaKalseki commented 9 years ago

Is this in a dev environment? If so, I recommend just adding it as source. That said, your error looks like a missing/old WAILA API.

Mineshopper commented 9 years ago

I'm using Minecraft.exe to launch. I've tried the latest Forge, then back to 1291, with the following files in the 1.7.10 mods folder: DragonAPI 1.7.10 V6f.jar.zip, RotaryCraft 1.7.10 V6f.jar.zip, Waila-1.5.10_1.7.10.jar

Still crashes as shown in pastebin.

ReikaKalseki commented 9 years ago

Have you tried without WAILA?

Mineshopper commented 9 years ago

Figured it out. The downloads came packaged as .jar.zip, so I just removed the .zip and they work now. Will actually look into the issue now!

EDIT: Maybe Firefox is doing it?

EDIT2: So far I have the pipes set up and a lot of Carpenter's blocks but haven't been able to reproduce this. There has been a similar bug where textures in the vicinity can randomly rotate, of which I have never been able to resolve. There must be something in common that I just can't figure out.

EDIT3: Actually.. occasionally the blocks will alter metadata while rendering to better approximate the block appearance. If incorrect coordinates are passed in it could cause something like this I think, especially if your pipes use metadata for connections.

ReikaKalseki commented 9 years ago

No, my pipes store connections in the TileEntity. I strongly suspect the actual render code is where the error is. Also, this happens when the CB block is anywhere in the render subchunk.

That said, altering the metadata of my pipes is a good way to crash the game. :P

Mineshopper commented 9 years ago

It is probably not setting incorrect metadata then. I'll keep investigating to see what I can find.

ReikaKalseki commented 9 years ago

For reference, my renderer and TileEntity class:

https://github.com/ReikaKalseki/RotaryCraft/blob/master/Base/TileEntity/TileEntityPiping.java

https://github.com/ReikaKalseki/RotaryCraft/blob/master/PipeBodyRenderer.java