search

MinetestForFun / server-minetestforfun-hungry_games

Repository of the subgame and mods of "MinetestForFun Hunger Games" server
https://www.xorhub.com
3 stars 1 forks source link

Need to check/investigate it #91

Closed BetterToAutomateTheWorld closed 8 years ago

BetterToAutomateTheWorld commented 8 years ago

Lymkwi commented 8 years ago

As far as I remember, when you chose to watch someone in the lobby before a game starts, you're considered as a skipper. I'll check the code though, but that's the most logical way of getting skip to work with spectating.

BetterToAutomateTheWorld commented 8 years ago

I agree, but we maybe need to add a _randommessages + some signs around the "eyes"(spectator blocks) to explain that

Lymkwi commented 8 years ago

So, I ran tests. It seems that when you watch someone and enter a game, you follow that person, but you're not considered as a player, but if you had voted before, your vote apparently stays, and when the game starts, you're kicked from spectating, while playing in the game (you still have hunger and health bar showing up) I'll fix that.

Lymkwi commented 8 years ago

I had to do a workaround... basically, watching someone else before going into a game will make you skip, but you'll stay as a skipper until you vote. Since hg's engine is closed in hungry_games/engines.lua, I have no control over the skip/vote/registrant variables.

https://github.com/MinetestForFun/server-minetestforfun-hungry_games/commit/01359e08820c5de0f3b07241097a9efccf0add3e