search

MinetestForFun / server-minetestforfun-skyblock

Repository of the subgame and mods of "MinetestForFun Skyblock" server
https://www.xorhub.com
6 stars 3 forks source link

Server Crash! #227

Closed aerozoic closed 7 years ago

aerozoic commented 7 years ago

Any player can crash the server simply by giving the command "/last-login playername random text that is long enough to trigger the error".

And the error from the logs:

2017-07-29 16:14:55: ERROR[Main]: ServerError: Lua: Runtime error from mod '*builtin*' in callback on_chat_message(): .../minetestforfun_skyblock/mods/mysql_auth/mysql/mysql.lua:1178: string too long

@ElementW ping because it's mysql.

Thanks to @YuGiOhJCJ for the report. :large_orange_diamond:

aerozoic commented 7 years ago

Was this fixed? :large_orange_diamond:

YuGiOhJCJ commented 7 years ago

No it is not fixed, I have just did the test and there is still a server crash when I type the command.

ElementW commented 7 years ago

My local tests show max allowed string length is 32, which turns out to be the max username length. I'll fix that as part of my local changes, but getting things upstream will be a bit trickier since I've split mysql_auth into another mysql_base mod requiring additional conifg. @Darcidride must just be aware of that.

ElementW commented 7 years ago

Fixed. Note this must be merged to master and then to the server before taking effect.

BetterToAutomateTheWorld commented 7 years ago

The server will be merged soon with the repository version Thank you for your work @ElementW