search

MinetestForFun / server-minetestforfun-skyblock

Repository of the subgame and mods of "MinetestForFun Skyblock" server
https://www.xorhub.com
6 stars 3 forks source link

Server crash #89

Closed BetterToAutomateTheWorld closed 8 years ago

BetterToAutomateTheWorld commented 8 years ago 
2016-02-27 09:54:58: ACTION[ServerThread]: Player Katie7168 tried to access [node under=15089,4,15938 above=15089,4,15937] from too far: d=142.42, max_d=140. ignoring.
2016-02-27 09:54:59: ACTION[ServerThread]: [skyblock] get_spawn() for Katie7168 is {x=15072,y=15072,z=15936}
2016-02-27 09:54:59: ACTION[ServerThread]: [skyblock] skyblock.feats.reset_level(Katie7168)
2016-02-27 09:54:59: ACTION[ServerThread]: [skyblock] skyblock.feats.update(Katie7168)
2016-02-27 09:54:59: ACTION[ServerThread]: [skyblock] get_spawn() for Katie7168 is {x=15072,y=15072,z=15936}
2016-02-27 09:54:59: ACTION[ServerThread]: Katie7168 damaged by 9 hp at (15093,-9.5,15933.2)
2016-02-27 09:54:59: ACTION[ServerThread]: [skyblock] skyblock.feats.reset_level(Katie7168)
2016-02-27 09:54:59: ACTION[ServerThread]: [skyblock] skyblock.feats.update(Katie7168)
2016-02-27 09:54:59: ACTION[ServerThread]: [skyblock] get_spawn() for Katie7168 is {x=15072,y=15072,z=15936}
2016-02-27 09:55:00: ACTION[ServerThread]: [skyblock] get_spawn() for Katie7168 is {x=15072,y=15072,z=15936}
2016-02-27 09:55:00: ACTION[ServerThread]: [skyblock] skyblock.feats.reset_level(Katie7168)
2016-02-27 09:55:00: ACTION[ServerThread]: [skyblock] skyblock.feats.update(Katie7168)
2016-02-27 09:55:00: ACTION[ServerThread]: [skyblock] get_spawn() for Katie7168 is {x=15072,y=15072,z=15936}
2016-02-27 09:55:00: ERROR[main]: UNRECOVERABLE error occurred. Stopping server. Please fix the following error:
2016-02-27 09:55:00: ERROR[main]: Lua: Double fault error from mod 'default' in callback item_OnPlace(): error in error handling

In thread 7f316dbac740:
/home/quentinbd/mff-skyblock/src/server.cpp:511: void Server::step(float): A fatal error occurred: Lua: Double fault error from mod 'default' in callback item_OnPlace(): error in error handling
Debug stacks:
DEBUG STACK FOR THREAD 7f3165015700:
#0  virtual void* EmergeThread::Thread()
(Leftover data: #1  MapBlock* ServerMap::loadBlock(v3s16))
(Leftover data: #2  void ServerMap::loadBlock(std::string*, v3s16, MapSector*, bool))
(Leftover data: #3  void ItemStack::deSerialize(std::istream&, IItemDefManager*))
DEBUG STACK FOR THREAD 7f3165a1c700:
#0  virtual void* CurlFetchThread::Thread()
DEBUG STACK FOR THREAD 7f3167269700:
#0  virtual void* ServerThread::Thread()
#1  void Server::Receive()
(Leftover data: #2  void Server::SendBlocks(float))
(Leftover data: #3  void RemoteClient::GetNextBlocks(ServerEnvironment*, EmergeManager*, float, std::vector<PrioritySortedBlockTransfer>&))
(Leftover data: #4  void Server::SendDeathscreen(irr::u16, bool, v3f))
(Leftover data: #5  void Server::SendHP(irr::u16, irr::u8))
(Leftover data: #6  void ItemStack::deSerialize(std::istream&, IItemDefManager*))
(Leftover data: #7  void ItemStack::deSerialize(std::istream&, IItemDefManager*))
DEBUG STACK FOR THREAD 7f316dbac740:
#0  int main(int, char**)
#1  Dedicated server branch
#2  void dedicated_server_loop(Server&, bool&)
#3  void Server::step(float)
(Leftover data: #4  void Server::SendAccessDenied_Legacy(irr::u16, const wstring&))
/home/quentinbd/script/start-mff-skyblock.sh : ligne 25 :  3877 Abandon                 (core dumped)/home/quentinbd/mff-skyblock/bin/minetestserver --world /home/quentinbd/mff-skyblock/worlds/minetestforfun-skyblock/ --config /home/quentinbd/mff-skyblock/minetest.conf --gameid minetestforfun_skyblock --port 30054
----------------------
Server restarted at samedi 27 février 2016, 09:55:42 (UTC+0100)
----------------------
Using game specified by --gameid on the command line
2016-02-27 09:55:42: ACTION[main]: [TimeRegulation] Loop started
2016-02-27 09:55:00: ACTION[ServerThread]: [skyblock] skyblock.feats.reset_level(Katie7168)
2016-02-27 09:55:00: ACTION[ServerThread]: [skyblock] skyblock.feats.update(Katie7168)
2016-02-27 09:55:00: ACTION[ServerThread]: [skyblock] get_spawn() for Katie7168 is {x=15072,y=15072,z=15936}
2016-02-27 09:55:00: ERROR[main]: UNRECOVERABLE error occurred. Stopping server. Please fix the following error:
2016-02-27 09:55:00: ERROR[main]: Lua: Double fault error from mod 'default' in callback item_OnPlace(): error in error handling

In thread 7f316dbac740:
/home/quentinbd/mff-skyblock/src/server.cpp:511: void Server::step(float): A fatal error occurred: Lua: Double fault error from mod 'default' in callback item_OnPlace(): error in error handling
Debug stacks:
DEBUG STACK FOR THREAD 7f3165015700:
#0  virtual void* EmergeThread::Thread()
(Leftover data: #1  MapBlock* ServerMap::loadBlock(v3s16))
(Leftover data: #2  void ServerMap::loadBlock(std::string*, v3s16, MapSector*, bool))
(Leftover data: #3  void ItemStack::deSerialize(std::istream&, IItemDefManager*))
DEBUG STACK FOR THREAD 7f3165a1c700:
#0  virtual void* CurlFetchThread::Thread()
DEBUG STACK FOR THREAD 7f3167269700:
#0  virtual void* ServerThread::Thread()
#1  void Server::Receive()
(Leftover data: #2  void Server::SendBlocks(float))
(Leftover data: #3  void RemoteClient::GetNextBlocks(ServerEnvironment*, EmergeManager*, float, std::vector<PrioritySortedBlockTransfer>&))
(Leftover data: #4  void Server::SendDeathscreen(irr::u16, bool, v3f))
(Leftover data: #5  void Server::SendHP(irr::u16, irr::u8))
(Leftover data: #6  void ItemStack::deSerialize(std::istream&, IItemDefManager*))
(Leftover data: #7  void ItemStack::deSerialize(std::istream&, IItemDefManager*))
DEBUG STACK FOR THREAD 7f316dbac740:
#0  int main(int, char**)
#1  Dedicated server branch
#2  void dedicated_server_loop(Server&, bool&)
#3  void Server::step(float)
(Leftover data: #4  void Server::SendAccessDenied_Legacy(irr::u16, const wstring&))
/home/quentinbd/script/start-mff-skyblock.sh : ligne 25 :  3877 Abandon                 (core dumped)/home/quentinbd/mff-skyblock/bin/minetestserver --world /home/quentinbd/mff-skyblock/worlds/minetestforfun-skyblock/ --config /home/quentinbd/mff-skyblock/minetest.conf --gameid minetestforfun_skyblock --port 30054
----------------------
Server restarted at samedi 27 février 2016, 09:55:42 (UTC+0100)
----------------------
Using game specified by --gameid on the command line
2016-02-24 15:31:55: ACTION[ServerThread]: starman54 digs default:chest at (15453,2,16680)
2016-02-24 15:31:56: ACTION[ServerThread]: starman54 digs default:chest at (15449,2,16680)
2016-02-24 15:32:30: ACTION[ServerThread]: starman54 digs xdecor:fire at (15465,5,16626)
2016-02-24 15:32:42: ACTION[ServerThread]: starman54 digs signs:sign_yard at (15457,6,16632)
2016-02-24 15:32:47: ACTION[ServerThread]: starman54 damaged by 4 hp at (15455.6,4.5,16633)
2016-02-24 15:32:50: ACTION[ServerThread]: starman54 digs xdecor:fire at (15457,5,16634)
2016-02-24 15:32:51: ACTION[ServerThread]: starman54 digs xdecor:fire at (15456,5,16633)
2016-02-24 15:32:52: ACTION[ServerThread]: starman54 digs xdecor:fire at (15458,5,16633)
2016-02-24 15:32:53: ACTION[ServerThread]: starman54 digs xdecor:fire at (15457,7,16633)
2016-02-24 15:32:54: ERROR[main]: UNRECOVERABLE error occurred. Stopping server. Please fix the following error:
2016-02-24 15:32:54: ERROR[main]: Lua: Double fault error from mod 'default' in callback item_OnPlace(): error in error handling

In thread 7fdc5bd75740:
/home/quentinbd/mff-skyblock/src/server.cpp:511: void Server::step(float): A fatal error occurred: Lua: Double fault error from mod 'default' in callback item_OnPlace(): error in error handling
Debug stacks:
DEBUG STACK FOR THREAD 7fdc4effe700:
#0  virtual void* EmergeThread::Thread()
(Leftover data: #1  MapBlock* ServerMap::loadBlock(v3s16))
(Leftover data: #2  void ServerMap::loadBlock(std::string*, v3s16, MapSector*, bool))
(Leftover data: #3  void ItemStack::deSerialize(std::istream&, IItemDefManager*))
DEBUG STACK FOR THREAD 7fdc54c37700:
#0  virtual void* CurlFetchThread::Thread()
DEBUG STACK FOR THREAD 7fdc55438700:
#0  virtual void* ServerThread::Thread()
#1  void Server::Receive()
(Leftover data: #2  void Server::SendBlocks(float))
(Leftover data: #3  void RemoteClient::GetNextBlocks(ServerEnvironment*, EmergeManager*, float, std::vector<PrioritySortedBlockTransfer>&))
(Leftover data: #4  void ItemStack::serialize(std::ostream&) const)
(Leftover data: #5  bool getCraftingResult(Inventory*, ItemStack&, std::vector<ItemStack>&, bool, IGameDef*))
(Leftover data: #6  void ItemStack::deSerialize(std::istream&, IItemDefManager*))
DEBUG STACK FOR THREAD 7fdc5bd75740:
#0  int main(int, char**)
#1  Dedicated server branch
#2  void dedicated_server_loop(Server&, bool&)
#3  void Server::step(float)
/home/quentinbd/script/start-mff-skyblock.sh : ligne 25 :  7077 Abandon                 /home/quentinbd/mff-skyblock/bin/minetestserver --world /home/quentinbd/mff-skyblock/worlds/minetestforfun-skyblock/ --config /home/quentinbd/mff-skyblock/minetest.conf --gameid minetestforfun_skyblock --port 30054
----------------------
Server restarted at mercredi 24 février 2016, 15:33:19 (UTC+0100)
----------------------
Using game specified by --gameid on the command line
2016-02-23 11:52:30: ACTION[ServerThread]: starman54 digs default:torch at (15453,5,16644)
2016-02-23 11:52:33: ACTION[ServerThread]: starman54 digs xdecor:fire at (15440,6,16647)
2016-02-23 11:53:36: ACTION[ServerThread]: starman54 places node xdecor:cauldron_empty at (15469,5,16674)
2016-02-23 11:53:36: ACTION[ServerThread]: facedir: 1
2016-02-23 11:53:53: ACTION[ServerThread]: starman54 uses bucket:bucket_empty, pointing at [node under=15457,5,16657 above=15457,6,16657]
2016-02-23 11:54:10: ACTION[ServerThread]: starman54 places node default:wood at (15469,5,16670)
2016-02-23 11:54:10: ACTION[ServerThread]: starman54 places node default:wood at (15469,5,16671)
2016-02-23 11:54:10: ACTION[ServerThread]: starman54 places node default:wood at (15469,5,16672)
2016-02-23 11:54:11: ACTION[ServerThread]: starman54 places node default:wood at (15469,5,16673)
2016-02-23 11:54:11: ACTION[ServerThread]: starman54 places node default:wood at (15469,5,16675)
2016-02-23 11:54:24: ERROR[main]: UNRECOVERABLE error occurred. Stopping server. Please fix the following error:
2016-02-23 11:54:24: ERROR[main]: Lua: Double fault error from mod 'default' in callback item_OnPlace(): error in error handling

In thread 7fda9fae9740:
/home/quentinbd/mff-skyblock/src/server.cpp:511: void Server::step(float): A fatal error occurred: Lua: Double fault error from mod 'default' in callback item_OnPlace(): error in error handling
Debug stacks:
DEBUG STACK FOR THREAD 7fda96f5a700:
#0  virtual void* EmergeThread::Thread()
(Leftover data: #1  MapBlock* ServerMap::loadBlock(v3s16))
(Leftover data: #2  void ServerMap::loadBlock(std::string*, v3s16, MapSector*, bool))
(Leftover data: #3  void ItemStack::deSerialize(std::istream&, IItemDefManager*))
DEBUG STACK FOR THREAD 7fda97961700:
#0  virtual void* CurlFetchThread::Thread()
DEBUG STACK FOR THREAD 7fda991ae700:
#0  virtual void* ServerThread::Thread()
#1  void Server::Receive()
(Leftover data: #2  void Server::SendBlocks(float))
(Leftover data: #3  void RemoteClient::GetNextBlocks(ServerEnvironment*, EmergeManager*, float, std::vector<PrioritySortedBlockTransfer>&))
(Leftover data: #4  void ItemStack::serialize(std::ostream&) const)
(Leftover data: #5  bool getCraftingResult(Inventory*, ItemStack&, std::vector<ItemStack>&, bool, IGameDef*))
(Leftover data: #6  void ItemStack::deSerialize(std::istream&, IItemDefManager*))
DEBUG STACK FOR THREAD 7fda9fae9740:
#0  int main(int, char**)
#1  Dedicated server branch
#2  void dedicated_server_loop(Server&, bool&)
#3  void Server::step(float)
(Leftover data: #4  void Server::SendAccessDenied_Legacy(irr::u16, const wstring&))
/home/quentinbd/script/start-mff-skyblock.sh : ligne 25 :  3899 Abandon                 (core dumped)/home/quentinbd/mff-skyblock/bin/minetestserver --world /home/quentinbd/mff-skyblock/worlds/minetestforfun-skyblock/ --config /home/quentinbd/mff-skyblock/minetest.conf --gameid minetestforfun_skyblock --port 30054
----------------------
Server restarted at mardi 23 février 2016, 11:55:07 (UTC+0100)
----------------------
Using game specified by --gameid on the command line
2016-02-23 11:55:07: ACTION[main]: [TimeRegulation] Loop started
Lymkwi commented 8 years ago

There is no precise source for the crash. We only know the callback and the mod in which is supposedly crashed. Actually, the only on_place callbacks implemented in default are uses of minetest.rotate_node and plant growth callbacks. Unless minetest.rotate_node is crashing the server there is no way default is responsible.

aerozoic commented 8 years ago

Here's another one....

2016-03-04 03:24:58: ACTION[ServerThread]: player PLAYERGIRL5 crafts xdecor:pressure_stone_off 2016-03-04 03:25:06: ACTION[ServerThread]: PLAYERGIRL5 places node xdecor:pressure_stone_off at (16411,23,16937) 2016-03-04 03:25:06: ACTION[ServerThread]: facedir: 3 2016-03-04 03:25:06: ACTION[ServerThread]: PLAYERGIRL5 places node xdecor:pressure_stone_off at (16412,22,16938) 2016-03-04 03:25:06: ACTION[ServerThread]: facedir: 0 2016-03-04 03:25:09: ACTION[ServerThread]: PLAYERGIRL5 digs xdecor:pressure_stone_off at (16412,22,16938) 2016-03-04 03:25:10: ACTION[ServerThread]: cristhian digs default:dirt_with_grass at (15040,4,15710) 2016-03-04 03:25:11: ACTION[ServerThread]: cristhian digs default:dirt_with_grass at (15039,4,15710) 2016-03-04 03:25:11: ACTION[ServerThread]: cristhian digs default:dirt_with_grass at (15040,4,15711) 2016-03-04 03:25:12: ACTION[ServerThread]: cristhian digs default:dirt_with_grass at (15039,4,15711) 2016-03-04 03:25:13: ACTION[ServerThread]: PLAYERGIRL5 places node xdecor:pressure_stone_off at (16412,23,16937) 2016-03-04 03:25:13: ACTION[ServerThread]: facedir: 2 2016-03-04 03:25:13: ACTION[ServerThread]: cristhian digs default:dirt_with_grass at (15041,4,15710) 2016-03-04 03:25:13: ACTION[ServerThread]: cristhian digs default:dirt_with_grass at (15041,4,15711) 2016-03-04 03:25:14: ERROR[main]: UNRECOVERABLE error occurred. Stopping server. Please fix the following error: 2016-03-04 03:25:14: ERROR[main]: Lua: Double fault error from mod 'xdecor' in callback node_on_timer(): error in error handling

And after the crash...

2016-03-04 03:32:57: ACTION[ServerThread]: CHAT: sory i step into a stone presure plate:( and it crushde us all

ObaniGemini commented 8 years ago

A stone pressure plate ? Isn't it a mesecons feature ?

BetterToAutomateTheWorld commented 8 years ago

@ObaniGemini No it's a new xdecor feature.

Surely linked to https://github.com/kilbith/xdecor/issues/34

ObaniGemini commented 8 years ago

https://github.com/kilbith/xdecor/commit/68a5559a291e50ed4998625cc7fca91105f9780d

Lymkwi commented 8 years ago

This includes the latest commits from xdecor : https://github.com/MinetestForFun/server-minetestforfun-skyblock/commit/1251a8acbe530d5b9d6a2b8a7485af336e5c85a1

Lymkwi commented 8 years ago

All the other crashs are unlogical according to the code in default.

BetterToAutomateTheWorld commented 8 years ago

Ok, then I closed this issue, thank you for the subtree/updates of xdecor

Lymkwi commented 8 years ago

I don't think the issue is completely solved. We still need to figure out what those crashs in default are about. @crabman77 has been investigating the nature of those errors, I'm not sure if he has committed anything yet.

aerozoic commented 8 years ago

2016-03-06 17:57:23: ERROR[main]: UNRECOVERABLE error occurred. Stopping server. Please fix the following error: 2016-03-06 17:57:23: ERROR[main]: Lua: Double fault error from mod 'xdecor' in callback node_on_timer(): error in error handling

BetterToAutomateTheWorld commented 8 years ago

Thank you @cessna151 we will investigate

ghost commented 8 years ago

trouvé. les plaques de pressions qui ne sont toujours pas codées comme il le faut.

CMaFaute, j'ai mergé le fix en me focalisant sur une erreur dans le code du fix. #GPasVuYenAvaitUneAutre :)

Lua: Runtime error from mod 'xdecor' in callback node_on_timer(): ...kyblock/bin/../games/Skyblock/mods/xdecor/mechanisms.lua:13: attempt to index local 'door' (a nil value)

xdecor ne supporte pas le mod protecteur et ses portes :(

crash xdecor fixé https://github.com/MinetestForFun/server-minetestforfun-skyblock/commit/ae6fdf0b1c1c5cdfbb129fd3da14ad99145be52c

BetterToAutomateTheWorld commented 8 years ago

@crabman77 tu peux appliquer sur creative aussi stp ? @kilbith ça devrait t'intéresser ^

kilbith commented 8 years ago

Merci pour le signal. Sinon ça serait sympa de faire profiter votre travail sur upstream. J'accepte aussi les pull-requests et les évalue aussi vite que possible.

kilbith commented 8 years ago

Il semble que le patch proposé par @crabman77 soit redondant voire inefficace, la vérification de la nouvelle API est déjà faite plus en amont dans le timer : https://github.com/kilbith/xdecor/blob/master/mechanisms.lua#L31

Etes-vous bien sûr d'avoir utilisé cette ligne de code sur votre serveur ?

ghost commented 8 years ago

@kilbith door.get est présente mais doit renvoyer un node si il est enregistré en tant que porte avec la nouvelle api, mais le mod protector à l'ancienne api, du coup door.get() renvoie nil https://github.com/MinetestForFun/server-minetestforfun-skyblock/blob/master/mods/doors/init.lua#L69

door:open() échoue donc https://github.com/kilbith/xdecor/blob/master/mechanisms.lua#L13

kilbith commented 8 years ago

Alors je viens de vérifier avec l'ancienne API du mod doors et rien d'anormal se passe. La petite vérification que j'avais ajouté fait bien son boulot.

ghost commented 8 years ago

Enfaite protector a sa propre fonction pour enregistrer les portes, donc les portes testées avec doors.get(node) sont inconnues de doors, d'ou le "nil" renvoyé, qui conduit à "nil:open(player)".

aerozoic commented 8 years ago

2016-03-13 00:36:17: ERROR[main]: UNRECOVERABLE error occurred. Stopping server. Please fix the following error: 2016-03-13 00:36:17: ERROR[main]: Lua: Double fault error from mod 'farming' in callback item_OnPlace(): error in error handling

And again...

2016-03-13 02:13:15: ERROR[main]: UNRECOVERABLE error occurred. Stopping server. Please fix the following error: 2016-03-13 02:13:15: ERROR[main]: Lua: Double fault error from mod 'default' in callback item_OnPlace(): error in error handling

BetterToAutomateTheWorld commented 8 years ago

default, farming, xdecor, that's all of our mods which use the "item_OnPlace()" function, maybe the problem isn't this mods but something else... quests system ? builtin ? default skyblock mods which call this mods ?

I don't know...

BetterToAutomateTheWorld commented 8 years ago

Close this issue, splitted here :