saplings not growing + jungle saplings server crash

[Cyberpangolin]

It's probably related to the recent moretree update #220 . Normal sapling seems to be inefficient. 20 minutes after planting 14 trees, nothing has grown - except my playing time ;).

I set it under high priority because wood is no longer renewable and is a critical ressource - we don't want devastated lands without any trace of wood like in Tianjin. I have just now planted a jungle tree, to check if it's common to all trees.

EDIT: it seems that loading a chunk with a jungle sapling kills the server. Someone should check the logs. It crashed twice when I was approaching my sapling, coming from a fresh-started game.

[Lymkwi]

I recently did an update of moretrees and plantlife_modpack regarding saplings. It may help, or not. https://github.com/MinetestForFun/minetest-minetestforfun-server/commit/57aad890949b6d61afdeef97130cd967578cb21b

[Cyberpangolin]

Now I can confirm: the jungle sapling kills the server if you plant it, wait a moment, and come back. I think it's the jungle tree not growing correctly.

@LeMagnesium I really hope your correction avoid these crashes.

[Cyberpangolin]

With the recent merge: no more crash. :+1:

Bad thing: saplings are still not growing. Or at least, they grow very slow so you cannot see one grow in 1 hour ingame.

[ObaniGemini]

1 hour in-game = 1 hour in the chunk ?

[ghost]

c'est un mauvais merge, le serveur crashait car la fonction prenait en argument la pos, c'est une table enorme a la place (un petit bout -> http://zerobin.qbuissondebon.info/?c5d14ad69b596a96#lAY+INNu0KYhc1p99km8W8KUNJIDXfJlu2B6i/PU1OA=) , donc crash. @Mg le fix si pas de pos.x|y|z ne fait plus crasher mais rien ne pousse du coup car la fonction est toujours avortée. c'est la galère à s'y retrouver dans le commit, il y a trop de mod updaté dans le seul commit.

[Cyberpangolin]

@ObaniGemini : yes, mainly.

If it's so complicated, why not come back to the "old" moretrees, that worked fine? What features do we -really- miss?

[Lymkwi]

@crabman77: I don't understand why. The merge seems correct. I only kept a few snippets of code that we added, none of which was touching any growth function nor sapling definition. I noticed that moretrees' repository has been updated since my last merge, I will update our mod consequently. EDIT: The new commits' name is "fix sapling growth". It will definetly fix this issue. EDIT2: https://github.com/MinetestForFun/minetest-minetestforfun-server/commit/e50a9be47729fca29f81fafdadfe737c05449a27

[BetterToAutomateTheWorld]

lol ! That was so simple O_o

[BetterToAutomateTheWorld]

Closed because it's fixed, re-oepned this issue if you don't see growing sapling tree ingame after the merge of this night.

[Cyberpangolin]

Then I have to re-open it T_T 30 minutes ingame, no tree. B91b confirmed to me he had no tree too.

[Lymkwi]

Apparently, not only moretrees was buggy, but one of biome_lib's function was constantely returning nil data.

[Cyberpangolin]

After discussion on IRC, this bug is probably related to minetest server's version. All we need is to upgrade the serv to 0.4.13. As it's now a "stable" release, it may come soon.

[BetterToAutomateTheWorld]

Indeed @Cyberpangolin , that's why i gave this issue the label Minetest 0.4.13-Release :)

[Cyberpangolin]

Now it grows! =)