MinetestForFun / server-minetestforfun

Repository of the subgame and mods of "MinetestForFun" server
https://www.xorhub.com
The Unlicense
27 stars 10 forks source link

removing 200+ skin and renaming #477

Closed ezamlinux closed 8 years ago

ezamlinux commented 8 years ago

Deleting of 200+ skin and renaming

I also made the changes suggested by @ObaniGemini

(If everything is OK , great thanks for your help ... i have some difficulties with GIT )

BetterToAutomateTheWorld commented 8 years ago

+1 for me, no particular comments to add except thank you :)

@LeMagnesium @crabman77 @ObaniGemini Please give your opinion

Lymkwi commented 8 years ago

Everything seems fine (except merging which somehow is messed up by modules/mods not being up to date, or changed). :+1:

ObaniGemini commented 8 years ago

REPOST

I think we can remove _"mff_character1", _"mff_character3", _"mff_character6", _"mff_character7", _"mff_character11" and _"character11", because they're kinda ugly.

I would replace them by:

_This was approved by @Ombridride because I made those skins and I personally think they're ugly/unusable (and they're not used, indeed). So this is my choice to remove the skins I asked to be on the server_

Ping @ezamlinux

ezamlinux commented 8 years ago

@LeMagnesium I worked on a fresh clone of MFF so everything was up to date. ( i push a specific branch , my master is old )

@ObaniGemini i have made the changes you proposed.

BetterToAutomateTheWorld commented 8 years ago

Waiting @crabman77 or @ObaniGemini approvments

ObaniGemini commented 8 years ago

For me it's a :+1: :+1: :)

ObaniGemini commented 8 years ago

By the way, will we need to make aliases for players using deleted skins ? Or will it be set to default automaticaly ?

BetterToAutomateTheWorld commented 8 years ago

Need confirmation, but normally it's a "grey"(transparent) skin until the player change again his skin

ezamlinux commented 8 years ago

@ObaniGemini @Ombridride

There are 2 potential situation

firstly : the player uses a skin with "ID" > 50 , then this skin will by default Secondly : If he used a skin's ID <50 , the new skin at this number. (or, by chance it will have its original skin if the number has not changed )

EDIT: Maybe think about sending a warning to the player.

ObaniGemini commented 8 years ago

Or make aliases for if number > 50, set skin to "character1" (there might be some kind of str("character", str(number)) in the code I think)

Lymkwi commented 8 years ago

Or make aliases for if number > 50, set skin to "character_1"

Just reset everyone's skin. They'll figure out they need to pick a new one.

Lymkwi commented 8 years ago

There, patch merged